"readme.md" did not exist on "5ac50092f7fbcac6b20a914386a6bf229ccd11be"
Resolve L2SS-363 "01 12 2021 get rw values from hardware"
2 unresolved threads
Changed RW caching to instead get the value from hardware.
Fixed bug in our unit tests that caused the scalar_R tests to read RW values instead of R values
Closes L2SS-363
Merge request reports
Activity
requested review from @mol
assigned to @snijder
77 def read_RW(device): 78 # print("read_RW {}, {}x{}, {}, {}".format(me.name, me.dim_x, me.dim_y, me.attr_type, me.value)) 79 """ 80 read_RW returns the value that was last written to the attribute 81 """ 82 try: 83 return device.value_dict[self] 84 except Exception as e: 85 raise Exception(f"Attribute read_RW function error, attempted to read value_dict with key: `{self}`, are you sure this exists?") from e 86 87 @only_in_states([DevState.STANDBY, DevState.ON], log=False) 88 @fault_on_error() 89 def write_RW(device, value): 77 def write_func_wrapper(device, value): 90 78 """ 91 79 _write_RW writes a value to this attribute changed this line in version 3 of the diff
102 """ if the attribute is of READ type, assign the read function to it""" 87 """ Assign the read function to the attribute""" 103 88 104 @only_in_states([DevState.STANDBY, DevState.ON], log=False) 105 @fault_on_error() 106 def read_R(device): 107 """ 108 _read_R reads the attribute value, stores it and returns it" 109 """ 110 device.value_dict[self] = self.read_function() 111 return device.value_dict[self] 89 @only_in_states([DevState.STANDBY, DevState.ON], log=False) 90 @fault_on_error() 91 def read_func_wrapper(device): 92 """ 93 _read_R reads the attribute value, stores it and returns it" changed this line in version 3 of the diff
added 125 commits
-
a66a51f4...e15625f7 - 124 commits from branch
master
- b38a5241 - Merge branch 'master' of https://git.astron.nl/lofar2.0/tango into...
-
a66a51f4...e15625f7 - 124 commits from branch
enabled an automatic merge when the pipeline for 3929d81c succeeds
mentioned in commit abf64b5a
Please register or sign in to reply