Remove log file

The log is covered by .gitignore, but it was added before .gitignore was created so it continued to be versioned. When we remove it, .gitignore should ensure it isn't recreated.

Addresses esap-general#102 (closed).

requested review from @lautenbach

changed the description

Hey @lautenbach — do you have time for a quick review?

Is the '../' really needed?

Well, sorta. Because of the way BASE_DIR is defined, it is necessary to say “go up a level then into logs” in order for the logs to land in the same place as they are now.

We could also do that with something like

LOG_FILE_NAME = os.path.join(os.path.dirname(BASE_DIR), "logs/esap.log")

but that looks even uglier to me.

The other option is just to use a relative path, but I guess that makes the location of the log dependent on the directory the user happens to be in when they start things up, which seems less than great.

So in short: I think this is a big ugly but the best compromise. But if it makes you really unhappy, let me know and I'll do something else! :-)

It does not make me unhappy haha. That's why I also approved it. Just merely the question like 'do we have to go up one level' and you answered it

...it made me unhappy. But I couldn't think of a better option. :-)

approved this merge request

mentioned in commit 39e03d8f

merged