Integrate setuptools_scm
All threads resolved!
All threads resolved!
Integrated automatic version information generation using setuptools_scm
in pyproject.toml
file.
To check that things work as expected, execute the following commands, while at the root of the current git repository:
# Create and activate virtualenv
python3 -m venv venv
. venv/bin/activate
# Upgrade pip
pip install -U pip
# Install my-awesome-app (the `-e` option is to do a developer install, not strictly necessary but handy):
pip install -e .
# Check it works
python -c 'import my_awesome_app; print(my_awesome_app.__version__)'
Edited by Marcel Loose
Merge request reports
Activity
requested review from @lukken
assigned to @loose
mentioned in issue #8 (closed)
- Resolved by Corné Lukken
Some observations I have from this:
- Our current setup.py file added for backwards compatibility does not use the scm integration and reports a different value.
- VERSION file should be removed with this system
- System picks up tags to determine version increases
Some possible complications with future ventures:
- If you use gitlab environments you might want to spawn jobs only for protected environment (to deploy), these environments might be determined from branches and patterns on tags. However, if the tag exists on another branch before it hits a protected branch the job will not be spawned...... This requires developers to delay tagging until after their patch is merged on master.
I think we can go forward with this system, generating the version from tags is just as easy (or easier) then having to change the file. This system also allows developers to choose to bump the version before or after the patch is merged to master where as bumping the file can only really be done beforehand.
requested review from @kliffen
mentioned in commit 7aed4541
Please register or sign in to reply