L2SS-876: Get current RECV values before updating through antennafield

Closes L2SS-876

added 1 commit

• 1ea328dd - L2SS-876: Improve docstrings for antennafield

Compare with previous version

added 1 commit

• 6cd0f1d6 - L2SS-876: Add tests for retaining values on recv from antennafield

Compare with previous version

marked this merge request as ready

added 26 commits

• 6cd0f1d6...48c437c4 - 22 commits from branch master
• 03c5fcc5 - L2SS-876: Get current RECV values before updating through antennafield
• 0f58ff28 - L2SS-876: Improve docstrings for antennafield
• cd85285c - L2SS-876: Add tests for retaining values on recv from antennafield
• e43e2377 - L2SS-876: Remove old tests

Compare with previous version

log_file

added 69 commits

• e43e2377...d0794baf - 65 commits from branch master
• f3581a10 - L2SS-876: Get current RECV values before updating through antennafield
• b40a8089 - L2SS-876: Improve docstrings for antennafield
• aef80834 - L2SS-876: Add tests for retaining values on recv from antennafield
• 56601361 - L2SS-876: Remove old tests

Compare with previous version

added 1 commit

• 9e8c25de - L2SS-876: Update class name in antennafield tests

Compare with previous version

Looks good, masked behaviour is a nice design.

2022-09-21T09:39:57.812 ERROR - AntennaField(STAT/AntennaField/1): Function failed. [error_wrapper in device_decorators.py:58]
Traceback (most recent call last):
  File "/home/tango/.local/lib/python3.7/site-packages/tangostationcontrol/devices/device_decorators.py", line 56, in error_wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/tango/server.py", line 1142, in cmd
    return get_worker().execute(f, self, *args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/tango/green.py", line 98, in execute
    return fn(*args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/tango/log4tango.py", line 141, in log_stream
    ret = f(*args, **kwargs)
  File "/home/tango/.local/lib/python3.7/site-packages/tangostationcontrol/devices/lofar_device.py", line 344, in prepare_hardware
    self._prepare_hardware()
  File "/home/tango/.local/lib/python3.7/site-packages/tangostationcontrol/common/lofar_logging.py", line 218, in inner
    return func(self, *args, **kwargs)
  File "/home/tango/.local/lib/python3.7/site-packages/tangostationcontrol/devices/antennafield.py", line 437, in _prepare_hardware
    self.proxy.write_attribute('ANT_mask_RW', self.read_attribute('Antenna_Usage_Mask_R'))
  File "/usr/local/lib/python3.7/dist-packages/tango/green.py", line 195, in greener
    return executor.run(fn, args, kwargs, wait=wait, timeout=timeout)
  File "/usr/local/lib/python3.7/dist-packages/tango/green.py", line 109, in run
    return fn(*args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/tango/device_proxy.py", line 1538, in __DeviceProxy__write_attribute
    return self._write_attribute(*args, **kwargs)
PyTango.DevFailed: DevFailed[

added 25 commits

• 9e8c25de...673aadb6 - 19 commits from branch master
• 9b7098db - L2SS-876: Get current RECV values before updating through antennafield
• 07362df4 - L2SS-876: Improve docstrings for antennafield
• fc83551f - L2SS-876: Add tests for retaining values on recv from antennafield
• 47611c37 - L2SS-876: Remove old tests
• 88fdaa63 - L2SS-876: Update class name in antennafield tests
• 7e0cc2d2 - L2SS-876: Fix proxy.write_attribute by numpy array casting

Compare with previous version

added 1 commit

• 40c6c715 - L2SS-876: Update antennafield integration tests

Compare with previous version

added 1 commit

• c91be878 - L2SS-876: Fix antennafield restore function

Compare with previous version

resolved all threads

mentioned in commit 068ddf5f

merged