L2SS-680: Add empty PDU device

Closes L2SS-680

approved this merge request

added 58 commits

• b9e946f6...d5e9d2d8 - 55 commits from branch master
• 3f863ff6 - L2SS-680: Add empty PDU device
• b6c4dba2 - L2SS-680: Readd PDU device to integration test
• 68d2d29b - Merge branch 'L2SS-680' of git.astron.nl:lofar2.0/tango into L2SS-680

Compare with previous version

changed the description

added 1 commit

• 263a2482 - L2SS-680: Remove volume rom pdu device

Compare with previous version

marked this merge request as draft

Do not merge:

tangostationcontrol.integration_test.default.devices.test_device_recv.TestDeviceRECV.test_device_read_all_attributes
--------------------------------------------------------------------------------------------------------------------
Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "/opt/lofar/tango/tangostationcontrol/tangostationcontrol/integration_test/default/devices/base.py", line 88, in test_device_read_all_attributes
    _ = self.proxy.read_attribute(attribute_name).value
      File "/usr/local/lib/python3.7/dist-packages/tango/green.py", line 195, in greener
    return executor.run(fn, args, kwargs, wait=wait, timeout=timeout)
      File "/usr/local/lib/python3.7/dist-packages/tango/green.py", line 109, in run
    return fn(*args, **kwargs)
      File "/usr/local/lib/python3.7/dist-packages/tango/device_proxy.py", line 441, in __DeviceProxy__read_attribute
    return __check_read_attribute(self._read_attribute(value, extract_as))
      File "/usr/local/lib/python3.7/dist-packages/tango/device_proxy.py", line 157, in __check_read_attribute
    raise DevFailed(*dev_attr.get_err_stack())
    PyTango.DevFailed: DevFailed[
DevError[
    desc = ValueError: cannot reshape array of size 1 into shape (3,)
           
  origin = Traceback (most recent call last):
  File "/usr/local/lib/python3.7/dist-packages/tango/server.py", line 136, in read_attr
    ret = worker.execute(read_method, self)
  File "/usr/local/lib/python3.7/dist-packages/tango/green.py", line 98, in execute
    return fn(*args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/tangostationcontrol/devices/recv.py", line 252, in read_Antenna_Field_Reference_ITRF_R
    ETRS_coordinates = numpy.array(self.Antenna_Field_Reference_ETRS).reshape(3)
ValueError: cannot reshape array of size 1 into shape (3,)
  reason = PyDs_PythonError
severity = ERR]
DevError[
    desc = Failed to read_attribute on device stat/recv/1, attribute Antenna_Field_Reference_ITRF_R
  origin = DeviceProxy::read_attribute()
  reason = API_AttributeFailed
severity = ERR]
]
    
The above exception was the direct cause of the following exception:
    Traceback (most recent call last):
      File "/opt/lofar/tango/tangostationcontrol/tangostationcontrol/integration_test/default/devices/base.py", line 90, in test_device_read_all_attributes
    raise AssertionError(f"Could not read attribute {attribute_name} from device {self.name}") from e
    AssertionError: Could not read attribute Antenna_Field_Reference_ITRF_R from device STAT/RECV/1
tangostationcontrol.integration_test.default.devices.test_device_sdp.TestDeviceSDP.test_device_read_all_attributes
------------------------------------------------------------------------------------------------------------------
Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "/opt/lofar/tango/tangostationcontrol/tangostationcontrol/integration_test/default/devices/base.py", line 88, in test_device_read_all_attributes
    _ = self.proxy.read_attribute(attribute_name).value
      File "/usr/local/lib/python3.7/dist-packages/tango/green.py", line 195, in greener
    return executor.run(fn, args, kwargs, wait=wait, timeout=timeout)
      File "/usr/local/lib/python3.7/dist-packages/tango/green.py", line 109, in run
    return fn(*args, **kwargs)
      File "/usr/local/lib/python3.7/dist-packages/tango/device_proxy.py", line 441, in __DeviceProxy__read_attribute
    return __check_read_attribute(self._read_attribute(value, extract_as))
      File "/usr/local/lib/python3.7/dist-packages/tango/device_proxy.py", line 157, in __check_read_attribute
    raise DevFailed(*dev_attr.get_err_stack())
    PyTango.DevFailed: DevFailed[
DevError[
    desc = Read value for attribute FPGA_signal_input_nof_blocks_R has not been updated
  origin = Device_3Impl::read_attributes_no_except
  reason = API_AttrValueNotSet
severity = ERR]
DevError[
    desc = Failed to read_attribute on device stat/sdp/1, attribute FPGA_signal_input_nof_blocks_R
  origin = DeviceProxy::read_attribute()
  reason = API_AttributeFailed
severity = ERR]
]

These two are fixed on master now.

added 31 commits

• 263a2482...e21958f4 - 27 commits from branch master
• dc8f31ca - L2SS-680: Add empty PDU device
• 52a4ffd7 - L2SS-680: Readd PDU device to integration test
• 87bbc882 - L2SS-680: Add empty PDU device
• 95ebf0ef - L2SS-680: Remove volume rom pdu device

Compare with previous version

rebased. lets see.

marked this merge request as ready

build is clean. merging.

merged

mentioned in commit a9e44401