L2SS-790: Removed duplicate steps spread across common base image

.gitlab-ci.yml

@@ -564,42 +564,27 @@ newline_at_eof:
     - flake8 --filename *.sh,*.conf,*.md,*.yml --select=W292 --exclude docker-compose/tango-prometheus-exporter,.tox,.egg-info,docker
 python_linting:
   stage: linting
-  before_script:
-    - sudo apt-get update
-    - sudo apt-get install -y git
   script:
     - cd tangostationcontrol
     - tox -e pep8
 bandit:
   stage: static-analysis
-  before_script:
-    - sudo apt-get update
-    - sudo apt-get install -y git
   script:
     - cd tangostationcontrol
     - tox -e bandit
 xenon:
   stage: static-analysis
   allow_failure: true
-  before_script:
-    - sudo apt-get update
-    - sudo apt-get install -y git
   script:
    - cd tangostationcontrol
    - tox -e xenon
 shellcheck:
   stage: static-analysis
-  before_script:
-    - sudo apt-get update
-    - sudo apt-get install -y shellcheck
   script:
 #     TODO(Corne): Ignore shell files in submodules
     - shellcheck **/*.sh
 sphinx-documentation:
   stage: documentation
-  before_script:
-    - sudo apt-get update
-    - sudo apt-get install -y git graphviz
   script:
     - cd tangostationcontrol
     - tox -e docs
@@ -608,9 +593,6 @@ sphinx-documentation:
       - tangostationcontrol/docs/build/
 unit_test:
   stage: unit-tests
-  before_script:
-    - sudo apt-get update
-    - sudo apt-get install -y git
   script:
     - cd tangostationcontrol
     - tox -e cover
@@ -675,8 +657,6 @@ wheel_packaging:
     paths:
       - tangostationcontrol/dist/*.whl
   before_script:
-    - sudo apt-get update
-    - sudo apt-get install -y git
     - pip3 install -r tangostationcontrol/test-requirements.txt
     - pip3 install -r docker-compose/itango/lofar-requirements.txt
   script:

docker-compose/lofar-device-base/Dockerfile

 ARG SOURCE_IMAGE
 FROM ${SOURCE_IMAGE}
 
-RUN sudo apt-get update && sudo apt-get install -y git g++ gcc python3-dev && sudo apt-get clean
-
+RUN sudo apt-get update && sudo apt-get install -y git g++ gcc shellcheck graphviz python3-dev && sudo apt-get clean
 
 COPY docker-compose/lofar-device-base/lofar-requirements.txt /lofar-requirements.txt
 RUN sudo pip3 install -r /lofar-requirements.txt