Skip to content
Snippets Groups Projects
Commit 21794442 authored by Nico Vermaas's avatar Nico Vermaas
Browse files

handle review comments

parent c82bfaae
No related branches found
No related tags found
1 merge request!361SDC-1423 use aggregation strategy
Pipeline #88806 passed
...@@ -51,14 +51,14 @@ class TestProcessedSummary(TestCase): ...@@ -51,14 +51,14 @@ class TestProcessedSummary(TestCase):
""" """
actual = self.task1.resume actual = self.task1.resume
self.assertEqual(actual, True) self.assertTrue(actual)
def test_processed_not_on_hold_for_different_strategy(self): def test_processed_not_on_hold_for_different_strategy(self):
""" """
this is a summary task, but it uses a workflow with an aggregation_strategy that should not hold the task this is a summary task, but it uses a workflow with an aggregation_strategy that should not hold the task
""" """
actual = self.task4.resume actual = self.task4.resume
self.assertEqual(actual, True) self.assertTrue(actual)
def test_processed_on_hold(self): def test_processed_on_hold(self):
""" """
...@@ -66,7 +66,7 @@ class TestProcessedSummary(TestCase): ...@@ -66,7 +66,7 @@ class TestProcessedSummary(TestCase):
""" """
actual = self.task2.resume actual = self.task2.resume
self.assertEqual(actual, False) self.assertFalse(actual)
def test_activity_is_processed(self): def test_activity_is_processed(self):
...@@ -75,18 +75,18 @@ class TestProcessedSummary(TestCase): ...@@ -75,18 +75,18 @@ class TestProcessedSummary(TestCase):
""" """
actual = self.task1.activity.is_processed actual = self.task1.activity.is_processed
self.assertEqual(actual, True) self.assertTrue(actual)
def test_has_summary_substring(self): def test_has_summary_substring(self):
""" """
task 2 only has the old summary filename test. Check if the task indeed gets seen as a summary_task task 2 only has the old summary filename test. Check if the task indeed gets seen as a summary_task
""" """
actual = self.task2.is_summary actual = self.task2.is_summary
self.assertEqual(actual, True) self.assertTrue(actual)
def test_is_summary(self): def test_is_summary(self):
""" """
task 3 only has the new 'is_summary' test. Check if the task indeed gets seen as a summary_task task 3 only has the new 'is_summary' test. Check if the task indeed gets seen as a summary_task
""" """
actual = self.task3.is_summary actual = self.task3.is_summary
self.assertEqual(actual, True) self.assertTrue(actual)
\ No newline at end of file \ No newline at end of file
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment