From 217944422705092b6dbb942000bf0045ab8da82d Mon Sep 17 00:00:00 2001
From: Vermaas <vermaas@astron.nl>
Date: Tue, 23 Jul 2024 08:40:36 +0200
Subject: [PATCH] handle review comments
---
.../tests/test_models_processed_summary.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/atdb/taskdatabase/tests/test_models_processed_summary.py b/atdb/taskdatabase/tests/test_models_processed_summary.py
index 261fa7db..19c75609 100644
--- a/atdb/taskdatabase/tests/test_models_processed_summary.py
+++ b/atdb/taskdatabase/tests/test_models_processed_summary.py
@@ -51,14 +51,14 @@ class TestProcessedSummary(TestCase):
"""
actual = self.task1.resume
- self.assertEqual(actual, True)
+ self.assertTrue(actual)
def test_processed_not_on_hold_for_different_strategy(self):
"""
this is a summary task, but it uses a workflow with an aggregation_strategy that should not hold the task
"""
actual = self.task4.resume
- self.assertEqual(actual, True)
+ self.assertTrue(actual)
def test_processed_on_hold(self):
"""
@@ -66,7 +66,7 @@ class TestProcessedSummary(TestCase):
"""
actual = self.task2.resume
- self.assertEqual(actual, False)
+ self.assertFalse(actual)
def test_activity_is_processed(self):
@@ -75,18 +75,18 @@ class TestProcessedSummary(TestCase):
"""
actual = self.task1.activity.is_processed
- self.assertEqual(actual, True)
+ self.assertTrue(actual)
def test_has_summary_substring(self):
"""
task 2 only has the old summary filename test. Check if the task indeed gets seen as a summary_task
"""
actual = self.task2.is_summary
- self.assertEqual(actual, True)
+ self.assertTrue(actual)
def test_is_summary(self):
"""
task 3 only has the new 'is_summary' test. Check if the task indeed gets seen as a summary_task
"""
actual = self.task3.is_summary
- self.assertEqual(actual, True)
\ No newline at end of file
+ self.assertTrue(actual)
\ No newline at end of file
--
GitLab