L2SS-409: additional shellcheck fix

bin/start-DS.sh

@@ -2,7 +2,7 @@
 function help()
 {
     why="${1}"
-    echo -e "*** Cannot start the Python device server.\n${why}\n\n* The Python file for the device server must be the 1st parameter that is provided.\n* The instance of this device server must be the 2nd parameter that is provided."
+    echo -e "*** Cannot start the Python device server.\\n${why}\\n\\n* The Python file for the device server must be the 1st parameter that is provided.\\n* The instance of this device server must be the 2nd parameter that is provided."
     exit -1
 }
 

sbin/run_integration_test.sh

 #!/bin/bash -e
 
-if [ -z "$LOFA20_DIR" ]; then
+if [ -z "$LOFAR20_DIR" ]; then
     # We assume we aren't in the PATH, so we can derive our path.
     # We need our parent directory.
-    LOFAR20_DIR_RELATIVE=`dirname "$0"`/..
+    LOFAR20_DIR_RELATIVE=$(dirname "$0")/..
 
     # As an absolute path
-    LOFAR20_DIR=`readlink -f "${LOFAR20_DIR_RELATIVE}"`
+    LOFAR20_DIR=$(readlink -f "${LOFAR20_DIR_RELATIVE}")
 fi
 
 # Start and stop sequence
@@ -18,7 +18,7 @@ make start databaseds dsconfig jupyter elk
 sleep 15
 
 # Update the dsconfig
-${LOFAR20_DIR}/sbin/update_ConfigDb.sh ${LOFAR20_DIR}/CDB/integration_ConfigDb.json
+"${LOFAR20_DIR}"/sbin/update_ConfigDb.sh "${LOFAR20_DIR}"/CDB/integration_ConfigDb.json
 
 cd "$LOFAR20_DIR/docker-compose" || exit 1
 make start sdptr-sim recv-sim unb2-sim

sbin/tag_and_push_docker_image.sh

-#!/usr/bin/env bash -e
+#!/usr/bin/env/bash -e
 
 # Tag and push which image version?
 DOCKER_TAG=latest