Merge branch 'master' into L2SS-358-darkrai-round-2

devices/clients/attribute_wrapper.py

@@ -154,7 +154,7 @@ class attribute_wrapper(attribute):
         try:
             self.read_function, self.write_function = client.setup_attribute(self.comms_annotation, self)
         except Exception as e:
-            raise Exception("Exception while setting %s attribute with annotation: '%s'", client.__class__.__name__, self.comms_annotation) from e
+            raise Exception(f"Exception while setting {client.__class__.__name__} attribute with annotation: {self.comms_annotation}") from e
 
     async def async_set_comm_client(self, client):
         """
@@ -163,7 +163,7 @@ class attribute_wrapper(attribute):
         try:
             self.read_function, self.write_function = await client.setup_attribute(self.comms_annotation, self)
         except Exception as e:
-            raise Exception("Exception while setting %s attribute with annotation: '%s'", client.__class__.__name__, self.comms_annotation) from e
+            raise Exception(f"Exception while setting {client.__class__.__name__} attribute with annotation: {self.comms_annotation}") from e
 
     def set_pass_func(self):
         def pass_func(value=None):

devices/clients/opcua_client.py

@@ -86,7 +86,9 @@ class OPCUAConnection(AsyncCommClient):
         ping the client to make sure the connection with the client is still functional.
         """
         try:
-            await self.client.send_hello()
+            # do a cheap call. NOTE: send_hello is not allowed after establishing a connection,
+            # so cannot be used here. see https://reference.opcfoundation.org/v104/Core/docs/Part6/7.1.3/
+            _ = await self.client.get_namespace_array()
         except Exception as e:
             raise IOError("Lost connection to server %s: %s", self._servername(), e)