Skip to content
Snippets Groups Projects

Feature/149 jobs frontend

Merged Klaas Kliffen requested to merge feature/149_jobs_frontend into master
All threads resolved!

Adds an overview of currently running jobs to the frontend

Edited by Klaas Kliffen

Merge request reports

Approved by

Merged by Klaas KliffenKlaas Kliffen 2 years ago (Jul 8, 2022 9:27am UTC)

Merge details

  • Changes merged into master with 50f80173 (commits were squashed).
  • Deleted the source branch.

Pipeline #33052 passed

Pipeline passed for 50f80173 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Fanna Lautenbach
    • Resolved by Gareth Hughes

      The code looks good to me.

      A couple of questions about the workings:

      • The list presented to the user is for all jobs or just for that users?
      • The results will be the results from the worker or the results of the job?
      • If a job ends in an error state, can an option for more information be provided? Or does that go in the results?
      • Could there be a filter on job state?
  • Klaas Kliffen added 3 commits

    added 3 commits

    • f0364836 - Deduplicate loadJobs
    • 97c6c0fe - Split JobList into View component
    • 908b90e1 - Split JobListItemAction from JobListItem

    Compare with previous version

  • Fanna Lautenbach
  • Fanna Lautenbach approved this merge request

    approved this merge request

  • Gareth Hughes approved this merge request

    approved this merge request

  • Klaas Kliffen added 1 commit

    added 1 commit

    • 4b423848 - Fix page always being set to 1

    Compare with previous version

  • Klaas Kliffen resolved all threads

    resolved all threads

  • Klaas Kliffen approved this merge request

    approved this merge request

  • Klaas Kliffen mentioned in commit 50f80173

    mentioned in commit 50f80173

  • merged

  • Please register or sign in to reply
    Loading