Skip to content
Snippets Groups Projects

Only fetch XTensor if needed

Merged Maik Nijhuis requested to merge ast-1640-no-xtensor-fetch into master
All threads resolved!

Since https://gitlab.com/aroffringa/aocommon/-/merge_requests/195, FetchXTensor.cmake includes add_compile_definitions directives which should be executed at the root of a repository.

Projects using schaapcommon and XTensor should thus include FetchXtensor.cmake themselves instead of relying on schaapcommon for including FetchXTensor.cmake.

DP3!1372 (merged) tests this schaapcommon branch with DP3. https://gitlab.com/aroffringa/wsclean/-/merge_requests/781 tests this schaapcommon branch with WSClean.

Edited by Maik Nijhuis

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Maik Nijhuis added 1 commit

    added 1 commit

    • 038c768a - Update comment before fetching xtensor

    Compare with previous version

  • Maik Nijhuis added 2 commits

    added 2 commits

    • 0b311a4f - Merge if(SCHAAPCOMMON_MASTER_PROJECT) sections; Remove install
    • 847a67e7 - Use CLANG_TIDY_FIXES in cmake and artifacts

    Compare with previous version

  • Maik Nijhuis resolved all threads

    resolved all threads

  • Maik Nijhuis added 1 commit

    added 1 commit

    • a9b799da - Remove generator expr for SCHAAPCOMMON_MASTER_PROJECT

    Compare with previous version

  • Tammo Jan Dijkema approved this merge request

    approved this merge request

  • merged

  • Maik Nijhuis mentioned in commit 2bb964df

    mentioned in commit 2bb964df

  • Please register or sign in to reply
    Loading