Move Gaussian drawing function from WSClean

This is a first refactoring step to get a function DrawGaussianToLm() in schaapcommon. I'll also need a DrawGaussianToXy() function later on, hence the Lm in the name.

The fft module has also been renamed to the more generic name math, as the presence of convolution operation in fft is already a bit dubious.

assigned to @offringa

changed the description

added 1 commit

• 16de2f15 - Fix install script

Compare with previous version

changed the description

requested review from @nimalan-m

The namespace in the files that are moved into math folder eg) restoreimage.cc/restoreimage.h are still schaapcommon::fft

I can't add comments on renamed files.

https://git.astron.nl/RD/schaapcommon/-/blob/move-draw-gaussian/src/math/restoreimage.cc#L22 https://git.astron.nl/RD/schaapcommon/-/blob/move-draw-gaussian/src/math/restoreimage.cc#L78

if (beam_major_axis == 0.0 && beam_minor_axis == 0.0)

if (beam_major_axis == 0.0L && beam_minor_axis == 0.0L)

added 1 commit

• ffe34477 - Review comment

Compare with previous version

Can this be an inline function?

changed this line in version 4 of the diff

added 1 commit

• 22b80e76 - Other review comments

Compare with previous version

Thanks @nimalan-m , all good comments. Should be all fixed.

approved this merge request

mentioned in commit 94c40260

merged