Refactor dijkstra splitter

requested review from @mnijhuis-tos

assigned to @jmmaljaars

added 1 commit

• c8b3514f - Make dijkstra splitter google style compliant

Compare with previous version

added 1 commit

• aaaf2d86 - Fix review comments

Compare with previous version

added 1 commit

• 4829ddf8 - Fix review comments

Compare with previous version

I'm not really happy with this refactoring, because it is pretty hard to see what it is being changed, as it combines moving files, changing var names and other changes, and some of that seems to touch functionality. Please don't change any behavior in this MR, like changing != to < or add asserts at the same time -- they need to be more stringently reviewed. Moreover, I'm not in favour of changing != to < altogether, since changing it to < doesn't fix problems, it just hides them, and it makes it less clear what the stopping condition of the for should be.

Also, in this case, why is it not sufficient to just move the implementation to a cc file and make the interface Google style compliant?

added 1 commit

• 68eb0d6f - Revert some changes that stretched the scope of this MR

Compare with previous version

approved this merge request

added 10 commits

• 68eb0d6f...d24466a9 - 6 commits from branch main
• 681dc2ec - Create implementation file for DijkstraSplitter
• ae68c1ce - Make dijkstra splitter google style compliant
• f16d3288 - Fix review comments
• c1d1d707 - Revert some changes that stretched the scope of this MR

Compare with previous version

resolved all threads

started a merge train

mentioned in commit 5bbc6e79

merged