Skip to content
Snippets Groups Projects

Refactor dijkstra splitter

Merged Jakob Maljaars requested to merge refactor-dijkstra-splitter into main
All threads resolved!

Merge request reports

Merge train pipeline #28774 passed

Merge train pipeline passed for dccb1ef2

Approved by
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Maik Nijhuis
  • Jakob Maljaars added 1 commit

    added 1 commit

    Compare with previous version

  • Jakob Maljaars added 1 commit

    added 1 commit

    Compare with previous version

    • Resolved by Andre Offringa

      I'm not really happy with this refactoring, because it is pretty hard to see what it is being changed, as it combines moving files, changing var names and other changes, and some of that seems to touch functionality. Please don't change any behavior in this MR, like changing != to < or add asserts at the same time -- they need to be more stringently reviewed. Moreover, I'm not in favour of changing != to < altogether, since changing it to < doesn't fix problems, it just hides them, and it makes it less clear what the stopping condition of the for should be.

  • Jakob Maljaars added 1 commit

    added 1 commit

    • 68eb0d6f - Revert some changes that stretched the scope of this MR

    Compare with previous version

  • Maik Nijhuis approved this merge request

    approved this merge request

  • Jakob Maljaars added 10 commits

    added 10 commits

    • 68eb0d6f...d24466a9 - 6 commits from branch main
    • 681dc2ec - Create implementation file for DijkstraSplitter
    • ae68c1ce - Make dijkstra splitter google style compliant
    • f16d3288 - Fix review comments
    • c1d1d707 - Revert some changes that stretched the scope of this MR

    Compare with previous version

  • Jakob Maljaars resolved all threads

    resolved all threads

  • Jakob Maljaars started a merge train

    started a merge train

  • Jakob Maljaars mentioned in commit 5bbc6e79

    mentioned in commit 5bbc6e79

  • Please register or sign in to reply
    Loading