Refactor dijkstra splitter
Merge request reports
Activity
requested review from @mnijhuis-tos
assigned to @jmmaljaars
added 1 commit
- c8b3514f - Make dijkstra splitter google style compliant
- Resolved by Jakob Maljaars
- Resolved by Jakob Maljaars
- Resolved by Jakob Maljaars
- Resolved by Jakob Maljaars
- Resolved by Jakob Maljaars
- Resolved by Maik Nijhuis
- Resolved by Jakob Maljaars
- Resolved by Jakob Maljaars
- Resolved by Jakob Maljaars
- Resolved by Jakob Maljaars
- Resolved by Jakob Maljaars
- Resolved by Jakob Maljaars
- Resolved by Jakob Maljaars
- Resolved by Andre Offringa
I'm not really happy with this refactoring, because it is pretty hard to see what it is being changed, as it combines moving files, changing var names and other changes, and some of that seems to touch functionality. Please don't change any behavior in this MR, like changing
!=
to<
or add asserts at the same time -- they need to be more stringently reviewed. Moreover, I'm not in favour of changing!=
to<
altogether, since changing it to<
doesn't fix problems, it just hides them, and it makes it less clear what the stopping condition of the for should be.
- Resolved by Andre Offringa
Also, in this case, why is it not sufficient to just move the implementation to a cc file and make the interface Google style compliant?
added 1 commit
- 68eb0d6f - Revert some changes that stretched the scope of this MR
added 10 commits
-
68eb0d6f...d24466a9 - 6 commits from branch
main
- 681dc2ec - Create implementation file for DijkstraSplitter
- ae68c1ce - Make dijkstra splitter google style compliant
- f16d3288 - Fix review comments
- c1d1d707 - Revert some changes that stretched the scope of this MR
Toggle commit list-
68eb0d6f...d24466a9 - 6 commits from branch
mentioned in commit 5bbc6e79