Skip to content
Snippets Groups Projects

Fix a bug involving uninitialized memory

Merged Andre Offringa requested to merge fix-uninitialized-memory into main
All threads resolved!

In the bounding mask calculation, the bounding box is increased when the size would not be even. The bounding mask values should cover the entire bounding box, but when the bounding box is increased like that, it wouldn't set the values that the increase in size include. I've also adapted the test so it includes testing this.

Edited by Andre Offringa

Merge request reports

Merged result pipeline #46028 passed

Merged result pipeline passed for 51db9414

Approved by

Merged by Andre OffringaAndre Offringa 1 year ago (Mar 22, 2023 12:55pm UTC)

Merge details

  • Changes merged into main with 012a044c (commits were squashed).
  • Deleted the source branch.

Pipeline #46043 passed

Pipeline passed for 012a044c on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Maik Nijhuis
  • Maik Nijhuis
  • Maik Nijhuis requested review from @mnijhuis-tos

    requested review from @mnijhuis-tos

  • Andre Offringa added 1 commit

    added 1 commit

    • 08af8d5c - Add comments after review, and one more 'optimalisation'

    Compare with previous version

  • Maik Nijhuis resolved all threads

    resolved all threads

  • In the future, the dijkstra splitter could benefit from using xtensor: If you create a 2-D aocommon::xt::Span for mask, you can avoid many manual indexing computations. But that's out of scope of this MR.

  • Maik Nijhuis approved this merge request

    approved this merge request

  • merged

  • Please register or sign in to reply
    Loading