AST-779 set up deconvolution repository
Merge request to migrate the deconvolution related functionality to the radler
repository.
When reviewing this MR, please pay attention to:
- repository structure
- namespacing
- CMake configuration
But please don't comment on code style (as far as this MR is concerned it's merely copy-paste work)
Merge request reports
Activity
assigned to @jmmaljaars
- Resolved by Jakob Maljaars
added 2 commits
added 1 commit
- 59741f9b - CMake changes to allow radler compiling as submodule
requested review from @mnijhuis-tos
- Resolved by Jakob Maljaars
- Resolved by Jakob Maljaars
added 1 commit
- 839308d9 - Manually account for changes in deconvolution settings
added 1 commit
- a1983082 - Add componentlist and simple clean test, adapt clang-format file for cpp 17
- Resolved by Jakob Maljaars
- Resolved by Jakob Maljaars
- Resolved by Jakob Maljaars
- Resolved by Jakob Maljaars
- Resolved by Maik Nijhuis
- Resolved by Jakob Maljaars
- Resolved by Maik Nijhuis
- cpp/algorithms/iuwtdeconvolution.h 0 → 100644
1 // Copyright (C) 2022 ASTRON (Netherlands Institute for Radio Astronomy) 2 // SPDX-License-Identifier: GPL-3.0-or-later 3 4 #ifndef RADLER_ALGORITHMS_IUWT_DECONVOLUTION_H_ 5 #define RADLER_ALGORITHMS_IUWT_DECONVOLUTION_H_ 6 7 #include <memory> 8 #include <string> 9 10 #include <aocommon/uvector.h> 11 12 #include "deconvolutionalgorithm.h" 13 #include "iuwtdeconvolutionalgorithm.h" 14 #include "../imageset.h" 15 16 // TODO: consider merging IUWTDeconvolutionAlgorithms into this class. No, a ticket number typically will be part of the outcome of spike AST-883.
Google Style suggests to add a ticket number, in this case I think AST-883 would be a good number.
changed this line in version 36 of the diff
- Resolved by Jakob Maljaars
- Resolved by Maik Nijhuis
- Resolved by Jakob Maljaars
- cpp/algorithms/simpleclean.h 0 → 100644
1 // Copyright (C) 2022 ASTRON (Netherlands Institute for Radio Astronomy) 2 // SPDX-License-Identifier: GPL-3.0-or-later 3 4 #ifndef RADLER_ALGORITHMS_SIMPLE_CLEAN_H_ 5 #define RADLER_ALGORITHMS_SIMPLE_CLEAN_H_ 6 7 #include <cstring> 8 9 #ifdef __SSE__ 10 #define USE_INTRINSICS Probably not. However, I don't think I will pick this up in the scope of this MR, it's going to be a bit of work, since this also requires refactoring
PeakFinder
.Please list this as an item for the discussions in spike AST-883.
changed this line in version 36 of the diff
- Resolved by Maik Nijhuis
- Resolved by Jakob Maljaars
- Resolved by Jakob Maljaars