Skip to content

AST-1567 Add integration test to WGridderPredict

Bas van der Tol requested to merge ast-1567-add-wgridderpredict-integration-test into master

The integration tests are based on the integration tests for IDGPredict ddecal/test/integration/tIDGPredict.py. The tests that do not involve DdeCal have been placed in steps/test/integration/tWGridderPredict.py The tests do use DdeCal have been placed in ddecal/test/integration/tWGridderPredictDdeCal.py

The following features have been added

  • Padding to a multiple of four. Image sizes that are not a multiple of four were not supported. The restriction comes from the faceting routines in schaapcommon. WGridderPredict now pads these images to a multiple of four. There are no automated tests for this feature, but @nicolas-slusarenko has used this feature in his demonstration. (TJD: this was added in !1305 (merged))

  • Store directions for extra data buffer in DpInfo. DdeCal needs to know the direction associated with the model data, to correctly write the solutions to h5parm. DpInfo now contains a map of strings to directions that is filled by WGridderPredict. DpInfo simply exposes the entire map. The alternative is to add functions for adding, removing and looking up entries. This is how DpBuffer exposes the extra data buffers. However, these functions together also provide full access to the map, just like exposing the map, since inserting, removing and looking up is everything that can be done with a map. There are no unit tests for this functionality, but it is used in the integration test. (TJD: this was added in !1304 (merged))

Edited by Tammo Jan Dijkema

Merge request reports