Skip to content
Snippets Groups Projects

AST-1567 Add integration test to WGridderPredict

Merged AST-1567 Add integration test to WGridderPredict
All threads resolved!
Merged Bas van der Tol requested to merge ast-1567-add-wgridderpredict-integration-test into master
All threads resolved!

The integration tests are based on the integration tests for IDGPredict ddecal/test/integration/tIDGPredict.py. The tests that do not involve DdeCal have been placed in steps/test/integration/tWGridderPredict.py The tests do use DdeCal have been placed in ddecal/test/integration/tWGridderPredictDdeCal.py

The following features have been added

  • Padding to a multiple of four. Image sizes that are not a multiple of four were not supported. The restriction comes from the faceting routines in schaapcommon. WGridderPredict now pads these images to a multiple of four. There are no automated tests for this feature, but @nicolas-slusarenko has used this feature in his demonstration. (TJD: this was added in !1305 (merged))

  • Store directions for extra data buffer in DpInfo. DdeCal needs to know the direction associated with the model data, to correctly write the solutions to h5parm. DpInfo now contains a map of strings to directions that is filled by WGridderPredict. DpInfo simply exposes the entire map. The alternative is to add functions for adding, removing and looking up entries. This is how DpBuffer exposes the extra data buffers. However, these functions together also provide full access to the map, just like exposing the map, since inserting, removing and looking up is everything that can be done with a map. There are no unit tests for this functionality, but it is used in the integration test. (TJD: this was added in !1304 (merged))

Edited by Tammo Jan Dijkema

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tammo Jan Dijkema
  • Some notes to self here. I will take over the role of Bas for this MR, someone else will have to review.

  • Tammo Jan Dijkema mentioned in merge request !1304 (merged)

    mentioned in merge request !1304 (merged)

  • Maik Nijhuis requested review from @mnijhuis-tos

    requested review from @mnijhuis-tos

  • added 36 commits

    • 3cbeb1ba...0b45b20e - 26 commits from branch master
    • 7e0166a5 - Add integration test for WGridderPredict step
    • bc62070a - Add model image padding to aligment of 4
    • 9220f44b - Use padded size when reading facets
    • 69bcdc18 - Add nthreads parset key
    • 471643cb - Add tWGridderPredict in steps, rename tWGridderPredict in ddecal
    • 92cc137c - Bump schaapcommon
    • f9729f2b - Pass directions of extra data via dpinfo
    • 100f2573 - Fix integration tests WGridderPredict
    • 84baaaba - Use H5ParmPredict instead of wsclean in integration test
    • d0c0687d - Fix WGridderPredict spectral integration test

    Compare with previous version

  • Tammo Jan Dijkema changed the description

    changed the description

  • added 1 commit

    Compare with previous version

  • Maik Nijhuis requested changes

    requested changes

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Tammo Jan Dijkema changed title from AST-1567 Add integration test to WGridderPredict, plus some improvements to AST-1567 Add integration test to WGridderPredict

    changed title from AST-1567 Add integration test to WGridderPredict, plus some improvements to AST-1567 Add integration test to WGridderPredict

  • added 17 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Tammo Jan Dijkema resolved all threads

    resolved all threads

  • Maik Nijhuis
  • Maik Nijhuis
  • Maik Nijhuis
  • Maik Nijhuis requested changes

    requested changes

  • added 1 commit

    Compare with previous version

  • Tammo Jan Dijkema resolved all threads

    resolved all threads

  • Maik Nijhuis approved this merge request

    approved this merge request

  • Tammo Jan Dijkema enabled an automatic merge when the pipeline for e0b5d524 succeeds

    enabled an automatic merge when the pipeline for e0b5d524 succeeds

  • mentioned in commit 67ed43f7

  • Please register or sign in to reply
    Loading