Skip to content
Snippets Groups Projects

Add docker image build and refactor template pipeline inclusion

Merged Corné Lukken requested to merge add-docker-image-build-2 into main
All threads resolved!

Explicitly build minimal docker images that installs and runs python package.

Upgrade gitlab ci to work on instantiated version of the template rather then including {{cookiecutter...}/.gitlab-ci.yml directly as that can contain template arguments.

Override all template jobs on the trigger include to depend on the instantiated pipeline.

Profit

Edited by Corné Lukken

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I haven't put your changes to the test, and I'm not a Gitlab CI guru, so I need to trust you on that :smile:

  • Maik Nijhuis
  • I don't understand the goal of this MR. What do you want to achieve? Could you add a description?

  • Maik Nijhuis
  • Maik Nijhuis requested changes

    requested changes

  • Corné Lukken changed the description

    changed the description

  • Corné Lukken added 1 commit

    added 1 commit

    Compare with previous version

  • Corné Lukken changed title from Add docker image build 2 to Add docker image build and refactor template pipeline inclusion

    changed title from Add docker image build 2 to Add docker image build and refactor template pipeline inclusion

  • Corné Lukken added 1 commit

    added 1 commit

    Compare with previous version

  • Corné Lukken added 1 commit

    added 1 commit

    Compare with previous version

  • Corné Lukken resolved all threads

    resolved all threads

  • Corné Lukken added 1 commit

    added 1 commit

    Compare with previous version

  • Addressed all the feedback

  • requested review from @mnijhuis-tos

  • Hannes Feldt approved this merge request

    approved this merge request

  • Hannes Feldt requested review from @loose

    requested review from @loose

  • Hannes Feldt bypassed reviews on this merge request

    bypassed reviews on this merge request

  • Hannes Feldt mentioned in commit eb4db91f

    mentioned in commit eb4db91f

  • merged

  • Please register or sign in to reply
    Loading