Clarify g_beamlet_scale.

applications/lofar2/designs/lofar2_unb2b_sdp_station/revisions/lofar2_unb2b_sdp_station_bf/tb_lofar2_unb2b_sdp_station_bf.vhd

@@ -30,8 +30,8 @@
 --        g_subband = 102 --> WG freq = 19.921875MHz
 --        g_ampl = 1.0 --> WG ampl = 2**13
 --   
---   2) Read current BSN from reg_bsn_scheduler_wg and write reg_bsn_scheduler_wg 
---      to trigger start of WG at BSN.
+--   2) Read current BSN from reg_bsn_scheduler_wg and write
+--      reg_bsn_scheduler_wg to trigger start of WG at BSN.
 --     
 --   3) Read and verify subband statistics (SST)
 --   
@@ -45,6 +45,9 @@
 --
 --   7) Verify 10GbE output header and output payload for g_beamlet.
 --
+-- Remark:
+-- * Use g_beamlet_scale = 2**10, for full scale WG and N_ant = 1, see [1]
+--
 -- Usage:
 --   > as 7    # default
 --   > as 12   # for detailed debugging
@@ -56,6 +59,10 @@
 --   Takes about   40 m when g_read_all_* = FALSE
 --   Takes about 1h 5 m when g_read_all_* = TRUE
 --
+-- References:
+-- [1] L4 SDPFW Decision: LOFAR2.0 SDP Firmware Quantization Model,
+--     https://support.astron.nl/confluence/pages/viewpage.action?spaceKey=L2M&title=L4+SDPFW+Decision%3A+LOFAR2.0+SDP+Firmware+Quantization+Model
+--
 -------------------------------------------------------------------------------
 LIBRARY IEEE, common_lib, unb2b_board_lib, i2c_lib, mm_lib, dp_lib, diag_lib, lofar2_sdp_lib, wpfb_lib, tech_pll_lib, tr_10GbE_lib, lofar2_unb2b_sdp_station_lib;
 USE IEEE.std_logic_1164.ALL;
@@ -83,7 +90,7 @@ ENTITY tb_lofar2_unb2b_sdp_station_bf IS
     g_wg_ampl           : REAL := 1.0;      -- WG normalized amplitude
     g_subband           : NATURAL := 102;   -- select g_subband at index 102 = 102/1024 * 200MHz = 19.921875 MHz
     g_beamlet           : NATURAL := 10;    -- map g_subband to g_beamlet index in beamset in range(c_sdp_S_sub_bf = 488)
-    g_beamlet_scale     : REAL := 1.0 / 2.0**9;  -- g_beamlet output scale factor
+    g_beamlet_scale     : REAL := 1.0 / 2.0**10;  -- g_beamlet output scale factor
     g_bf_gain           : REAL := 1.0;      -- g_beamlet BF weight normalized gain
     g_bf_phase          : REAL := 30.0;      -- g_beamlet BF weight phase rotation in degrees
     g_read_all_SST      : BOOLEAN := FALSE;  -- when FALSE only read SST for g_subband, to save sim time

applications/lofar2/designs/lofar2_unb2c_sdp_station/revisions/lofar2_unb2c_sdp_station_bf/tb_lofar2_unb2c_sdp_station_bf.vhd

@@ -102,8 +102,9 @@
 --        View rx_beamlet_cnt (in analog format)
 --
 -- Remark:
--- . The c_wg_phase_offset and c_subband_phase_offset are used to tune the WG
+-- * The c_wg_phase_offset and c_subband_phase_offset are used to tune the WG
 --   phase reference to 0.0 degrees at the start (sop)
+-- * Use g_beamlet_scale = 2**10, for full scale WG and N_ant = 1, see [1]
 --
 -- Usage:
 --   > as 7    # default
@@ -116,6 +117,10 @@
 --   Takes about 1h  1 m when g_read_all_* = FALSE
 --   Takes about 1h 30 m when g_read_all_* = TRUE
 --
+-- References:
+-- [1] L4 SDPFW Decision: LOFAR2.0 SDP Firmware Quantization Model,
+--     https://support.astron.nl/confluence/pages/viewpage.action?spaceKey=L2M&title=L4+SDPFW+Decision%3A+LOFAR2.0+SDP+Firmware+Quantization+Model
+--
 -------------------------------------------------------------------------------
 LIBRARY IEEE, common_lib, unb2c_board_lib, i2c_lib, mm_lib, dp_lib, diag_lib, lofar2_sdp_lib, wpfb_lib, tech_pll_lib, tr_10GbE_lib, lofar2_unb2c_sdp_station_lib;
 USE IEEE.std_logic_1164.ALL;

applications/lofar2/designs/lofar2_unb2c_sdp_station/revisions/lofar2_unb2c_sdp_station_bf_ring/tb_lofar2_unb2c_sdp_station_bf_ring.vhd

@@ -102,8 +102,9 @@
 --        View rx_beamlet_cnt (in analog format)
 --
 -- Remark:
--- . The c_wg_phase_offset and c_subband_phase_offset are used to tune the WG
+-- * The c_wg_phase_offset and c_subband_phase_offset are used to tune the WG
 --   phase reference to 0.0 degrees at the start (sop)
+-- * Use g_beamlet_scale = 2**10, for full scale WG and N_ant = 1, see [1]
 --
 -- Usage:
 --   > as 7    # default
@@ -115,6 +116,10 @@
 --   > run -a  
 --   Takes about 1h 58m when g_read_all_* = FALSE
 --
+-- References:
+-- [1] L4 SDPFW Decision: LOFAR2.0 SDP Firmware Quantization Model,
+--     https://support.astron.nl/confluence/pages/viewpage.action?spaceKey=L2M&title=L4+SDPFW+Decision%3A+LOFAR2.0+SDP+Firmware+Quantization+Model
+--
 -------------------------------------------------------------------------------
 LIBRARY IEEE, common_lib, unb2c_board_lib, i2c_lib, mm_lib, dp_lib, diag_lib, lofar2_sdp_lib, wpfb_lib, tech_pll_lib, tr_10GbE_lib, lofar2_unb2c_sdp_station_lib;
 USE IEEE.std_logic_1164.ALL;