Skip to content
Snippets Groups Projects

Resolve TMSS-345

Merged Resolve TMSS-345
TMSS-345 into master
All threads resolved!
Merged Jörn Künsemöller requested to merge TMSS-345 into master
All threads resolved!

Closes TMSS-345

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Auke Klazema
    Auke Klazema @klazema ·
    Contributor

    Nice clean implementation. Good that there are two versions of the conversion. I'm not a big fan of all the defaults. I would like things to be more explicit. This makes the intent of the function more clear. To have all the options I would have more specialized versions of the conversions. So one for the current time and the core and combinations. This results in lots of smaller functions and maybe that creates a jungle which is not nice either :(. Not need for changes. I will merge the ticket.

    Edited by Auke Klazema
  • Auke Klazema resolved all threads

    resolved all threads

  • Auke Klazema merged

    merged

  • Auke Klazema mentioned in commit 6e203401

    mentioned in commit 6e203401

    • Please register or sign in to reply