Task #8264: Remove superfluous check for 4-bit mode in BandPassCorrection...

Task #8264: Remove superfluous check for 4-bit mode in BandPassCorrection (station data is not even used in that kernel)

RTCP/Cobalt/GPUProc/share/gpu/kernels/BandPassCorrection.cu

@@ -33,7 +33,6 @@
  * - @c NR_CHANNELS_1: a multiple of 16 
  * - @c NR_CHANNELS_2: > 0 
  * - @c NR_SAMPLES_PER_CHANNEL: > a multiple of 16
- * - @c NR_BITS_PER_SAMPLE: 8 or 16
  * - @c DO_BANDPASS_CORRECTION: if defined, perform bandpass correction
  */
 
@@ -59,11 +58,6 @@
 #error Precondition violated: NR_SAMPLES_PER_CHANNEL > 0
 #endif
 
-#if !(NR_BITS_PER_SAMPLE == 16 || NR_BITS_PER_SAMPLE == 8)
-#error Precondition violated: NR_BITS_PER_SAMPLE == 16 || NR_BITS_PER_SAMPLE == 8
-#endif
-
-
 typedef  fcomplex (* OutputDataType)[NR_STATIONS][NR_CHANNELS_1 * NR_CHANNELS_2][NR_SAMPLES_PER_CHANNEL][NR_POLARIZATIONS];
 typedef  fcomplex (* InputDataType)[NR_STATIONS][NR_POLARIZATIONS][NR_CHANNELS_1][NR_SAMPLES_PER_CHANNEL][NR_CHANNELS_2];
 typedef  const float (* BandPassFactorsType)[NR_CHANNELS_1 * NR_CHANNELS_2];

RTCP/Cobalt/GPUProc/src/cuda/Kernels/BandPassCorrectionKernel.cc

@@ -47,7 +47,6 @@ namespace LOFAR
     BandPassCorrectionKernel::Parameters::Parameters(const Parset& ps) :
       Kernel::Parameters("bandpassCorrection"),
       nrStations(ps.settings.antennaFields.size()),
-      nrBitsPerSample(ps.settings.nrBitsPerSample),
 
       nrDelayCompensationChannels(ps.settings.beamFormer.nrDelayCompensationChannels),
       nrHighResolutionChannels(ps.settings.beamFormer.nrHighResolutionChannels),
@@ -127,8 +126,6 @@ namespace LOFAR
         KernelFactoryBase::compileDefinitions(itsParameters);
 
       defs["NR_STATIONS"] = lexical_cast<string>(itsParameters.nrStations);
-      defs["NR_BITS_PER_SAMPLE"] =
-        lexical_cast<string>(itsParameters.nrBitsPerSample);
 
       defs["NR_CHANNELS_1"] =
         lexical_cast<string>(itsParameters.nrDelayCompensationChannels);

RTCP/Cobalt/GPUProc/src/cuda/Kernels/BandPassCorrectionKernel.h

@@ -51,7 +51,6 @@ namespace LOFAR
       {
         Parameters(const Parset& ps);
         unsigned nrStations;
-        unsigned nrBitsPerSample;
 
         unsigned nrDelayCompensationChannels;
         unsigned nrHighResolutionChannels;