SW-465: Replaced print statement by logging. Added more logging about email notification.

CEP/Pipeline/framework/lofarpipe/support/loggingdecorators.py

@@ -176,6 +176,8 @@ def _send_mail_notification(calling_object, message):
         "sos@astron.nl"
     ]
 
+    calling_object.logger.info("creating email notification...")
+
     # get the active stack
     active_stack_data = '???'
     try:
@@ -187,8 +189,8 @@ def _send_mail_notification(calling_object, message):
 
             active_stack_data = simplyfied_pipeline_xml.toprettyxml(
                 encoding='ascii')
-    except:
-        pass
+    except Exception as e:
+        calling_object.logger.error(e)
 
     # get the Obsid and pipeline name add to subjecy title
     obsid = '???'
@@ -196,8 +198,8 @@ def _send_mail_notification(calling_object, message):
     try:
         obsid = os.path.basename(calling_object.__file__)
         jobname = calling_object.inputs['job_name']
-    except:
-        pass
+    except Exception as e:
+        calling_object.logger.error(e)
 
     subject = "Failed pipeline run {0}: {1}".format(obsid, jobname)
 
@@ -210,11 +212,12 @@ def _send_mail_notification(calling_object, message):
         pconfig = PipelineEmailConfig()
         error_sender = pconfig['error-sender']  # provoke_exception if key missing
     except Exception as e:
-        print e
-        # raise Exception("loggingdecorators.py: Could not find the pipeline email configuration file: %s" % (e) )
+        calling_object.logger.error(e)
         error_sender = "noreply@lofar.eu"
+        calling_object.logger.warn("Could not find sender address. Using default: %s", error_sender)
 
     for entry in mail_list:
+        calling_object.logger.info("sending email notification '%s' to %s", subject, entry)
         _mail_msg_to(error_sender, entry, subject, msg)