SW-612: Lock the casarest version to commit 2350d906194979d70448bf869bf628c24a0e4c19

Otherwise it is tried to compile "latest" which is master and that has already
moved on to use the casacore 3 namespace.

Docker/lofar-base/Dockerfile.tmpl

@@ -18,7 +18,7 @@ ENV DEBIAN_FRONTEND=noninteractive \
 # versions
 #
 ENV CASACORE_VERSION=2.2.0 \
-    CASAREST_VERSION=latest \
+    CASAREST_VERSION=2350d906194979d70448bf869bf628c24a0e4c19 \
     PYTHON_CASACORE_VERSION=2.1.2 \
     BOOST_VERSION=1.58
 
@@ -83,7 +83,7 @@ ENV  CASARCFILES=${INSTALLDIR}/casarc
 RUN apt-get update && apt-get install -y git cmake g++ gfortran libboost-system-dev libboost-thread-dev libhdf5-dev libcfitsio3-dev wcslib-dev libopenblas-dev && \
     mkdir -p ${INSTALLDIR}/casarest/build && \
     cd ${INSTALLDIR}/casarest && git clone https://github.com/casacore/casarest.git src && \
-    if [ "${CASAREST_VERSION}" != "latest" ]; then cd ${INSTALLDIR}/casarest/src && git checkout tags/v${CASAREST_VERSION}; fi && \
+    if [ "${CASAREST_VERSION}" != "latest" ]; then cd ${INSTALLDIR}/casarest/src && git checkout ${CASAREST_VERSION}; fi && \
     cd ${INSTALLDIR}/casarest/build && cmake -DCMAKE_INSTALL_PREFIX=${INSTALLDIR}/casarest -DCASACORE_ROOT_DIR=${INSTALLDIR}/casacore -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_FLAGS="-std=c++11 -O2 -march=native -DNDEBUG" ../src/ && \
     cd ${INSTALLDIR}/casarest/build && make -j ${J} && \
     cd ${INSTALLDIR}/casarest/build && make install && \