Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
LOFAR
Manage
Activity
Members
Labels
Plan
Issues
Wiki
Jira issues
Open Jira
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
RadioObservatory
LOFAR
Commits
80cacea6
Commit
80cacea6
authored
2 years ago
by
Mario Raciti
Browse files
Options
Downloads
Patches
Plain Diff
TMSS-656
: Cleanup
parent
c8820377
No related branches found
No related tags found
1 merge request
!981
Resolve TMSS-656
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
SAS/TMSS/backend/src/tmss/workflowapp/flows/schedulingunitflow.py
+0
-11
0 additions, 11 deletions
.../backend/src/tmss/workflowapp/flows/schedulingunitflow.py
with
0 additions
and
11 deletions
SAS/TMSS/backend/src/tmss/workflowapp/flows/schedulingunitflow.py
+
0
−
11
View file @
80cacea6
...
@@ -44,17 +44,6 @@ class Conditional(Signal):
...
@@ -44,17 +44,6 @@ class Conditional(Signal):
node is reached, but after a prior If node evaluated the corresponding TMSS property based on which it still expects
node is reached, but after a prior If node evaluated the corresponding TMSS property based on which it still expects
a signal.
a signal.
Also see https://support.astron.nl/jira/browse/TMSS-1562
Also see https://support.astron.nl/jira/browse/TMSS-1562
# todo: I
'
m not 100% sure about this one...
# I get the race condition part, so I see why we cannot simply to an If node followed by a Signal node.
# What I don
'
t get is why we need to augment the two, since to me they follow very different concepts.
# In BPMN, a Conditional seems to simply block on a condition check until the condition is met. This
# should not be related in any way to Signals. So while I do see that this implementation of a conditionally
# active Signal node works, I think it is A) probably not a correctly named entity (
"
IfElseSignal
"
?) and B)
# I wonder if a polling solution is more straight-forward. I would expect a (probably polling) implementation of
# a Conditional Node in Viewflow, but at least I don
'
t see it. But I think I would find an If-Node that loops back
# on itself as long as the condition is not met quite a bit clearer than this solution.
# I can see it
'
s nicer than polling, but somehow this mix of condition check via ORM and triggering signals on
# messages on a property change in the same node is brushing me the wrong way.
"""
"""
task_type
=
"
HUMAN
"
# makes it show up in the unassigned task lists
task_type
=
"
HUMAN
"
# makes it show up in the unassigned task lists
activation_class
=
ConditionalActivation
activation_class
=
ConditionalActivation
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment