Task #2699: Fixed a recently introduced bug in vdsmaker. You cannot delete...

Task #2699: Fixed a recently introduced bug in vdsmaker. You cannot delete items from the vdsnames list by job index, because deleting items changes the posiition of the remaining items and the length of the list (causing a IndexError).

CEP/Pipeline/recipes/sip/master/vdsmaker.py

@@ -103,9 +103,10 @@ class vdsmaker(BaseRecipe, RemoteCommandRecipeMixIn):
                 )
             )
         self._schedule_jobs(jobs, max_per_node=self.inputs['nproc'])
-        for idx, job in enumerate(jobs):
-            if job.results['returncode'] != 0:
-                del vdsnames[idx]
+        vdsnames = [
+            vds for vds, job in zip(vdsnames, jobs) 
+            if job.results['returncode'] == 0
+        ]
 
         # *********************************************************************
         # 3. Combine VDS files to produce GDS