SSB-47: Refactor the application of the gains

CAL/CalibrationCommon/lib/datacontainers/calibration_table.py

@@ -102,7 +102,7 @@ class CalibrationTable:
         new_calibration_table.calibration_date = calibration_date
         new_calibration_table.comment = comment
 
-        new_calibration_table.data = gains
+        new_calibration_table.data *= gains
         return new_calibration_table
 
     def frequencies(self) -> ndarray:

CAL/CalibrationProcessing/lib/convert/calibration_table.py

 from numpy import ndarray
 from lofar.calibration.common.datacontainers.holography_dataset import HolographyDataset
-from numpy import array, exp
+from numpy import zeros_like, exp
 from datetime import datetime, date
 from lofar.calibration.common.coordinates import mjd_to_astropy_time
 import logging
@@ -45,7 +45,7 @@ def compute_calibration_table(dataset: HolographyDataset, comment):
 
     for mode, calibration_table in zip(modes, calibration_tables):
         frequencies = calibration_table.frequencies() * _MHZ_TO_HZ
-        data = array(calibration_table.data)
+        data = zeros_like(calibration_table.data)
         for polarization in interpolated_gains:
             for antenna in interpolated_gains[polarization]:
                 gains_per_antenna = interpolated_gains[polarization][antenna]
@@ -54,7 +54,7 @@ def compute_calibration_table(dataset: HolographyDataset, comment):
                 rcu_id = antenna_polarization_mode_to_rcu(int(antenna),
                                                           polarization,
                                                           int(mode))
-                data[:, rcu_id] *= derived_gains
+                data[:, rcu_id] = derived_gains
         observation_date = mjds_to_datetime(dataset.start_time)
         observation_date_formatted = observation_date.strftime(_DATETIME_FORMAT)