TMSS-2146: type hinting and logging

LCS/PyCommon/subprocess_utils.py

@@ -25,7 +25,7 @@ def wrap_composite_command(cmd):
     return '''"%s" ''' % (cmd if isinstance(cmd, str) else ' '.join(cmd))
 
 
-def _convert_bytes_tuple_to_strings(bytes_tuple):
+def _convert_bytes_tuple_to_strings(bytes_tuple: (bytes, bytes)) -> (str, str):
     """Helper function for subprocess.communicate() and/or subprocess.check_output which changed from python2 to python3.
     This function returns the bytes in the bytes_tuple_tuple to utf-8 strings.
     You can use this to get the "normal" python2 subprocess behaviour back for functions like check_output and/or communicate."""
@@ -34,7 +34,7 @@ def _convert_bytes_tuple_to_strings(bytes_tuple):
                  else x
                  for x in bytes_tuple)
 
-def communicate_returning_strings(proc, input=None):
+def communicate_returning_strings(proc, input=None) -> (str, str):
     """Helper function for subprocess.communicate() which changed from python2 to python3.
     This function waits for the subprocess to finish and returns the stdout and stderr as utf-8 strings, just like python2 did."""
     return _convert_bytes_tuple_to_strings(proc.communicate(input=input))
@@ -135,7 +135,7 @@ class PipeReader:
             logger.debug("stopping %s", self.__thread.name)
             self.__stop_event.set()
             self.__thread.join()
-            logger.info("stopped %s", self.__thread.name)
+            logger.debug("stopped %s", self.__thread.name)
             self.__thread = None
 
     def __enter__(self):