Skip to content
Snippets Groups Projects
Commit 2f5aa206 authored by Jan David Mol's avatar Jan David Mol
Browse files

Task #11059: Disable O_DIRECT as it provides abysmal performance on the current CEP4 settings

parent d9ccc6bc
No related branches found
No related tags found
No related merge requests found
...@@ -21,11 +21,32 @@ ...@@ -21,11 +21,32 @@
#ifndef LOFAR_STORAGE_MSWRITERFILE_H #ifndef LOFAR_STORAGE_MSWRITERFILE_H
#define LOFAR_STORAGE_MSWRITERFILE_H #define LOFAR_STORAGE_MSWRITERFILE_H
// O_DIRECT gave us bad performance on CEP4. Compare:
/*
root@cpu01 ~]# dd if=/dev/zero of=/data/test/throughput.dd bs=104857600 count=10 oflag=direct
10+0 records in
10+0 records out
1048576000 bytes (1.0 GB) copied, 60.8431 s, 17.2 MB/s
[root@cpu01 ~]# dd if=/dev/zero of=/data/test/throughput.dd bs=104857600 count=10
10+0 records in
10+0 records out
1048576000 bytes (1.0 GB) copied, 0.879391 s, 1.2 GB/s
*/
//#define USE_O_DIRECT
#ifdef USE_O_DIRECT
#include "FastFileStream.h"
#else
#include <Stream/FileStream.h>
#endif
#include <string> #include <string>
#include <CoInterface/StreamableData.h> #include <CoInterface/StreamableData.h>
#include "MSWriter.h" #include "MSWriter.h"
#include "FastFileStream.h"
namespace LOFAR namespace LOFAR
{ {
...@@ -49,7 +70,11 @@ namespace LOFAR ...@@ -49,7 +70,11 @@ namespace LOFAR
virtual size_t getDataSize(); virtual size_t getDataSize();
protected: protected:
#ifdef USE_O_DIRECT
FastFileStream itsFile; FastFileStream itsFile;
#else
FileStream itsFile;
#endif
}; };
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment