Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
LOFAR
Manage
Activity
Members
Labels
Plan
Issues
Wiki
Jira issues
Open Jira
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
RadioObservatory
LOFAR
Commits
2dac1aba
Commit
2dac1aba
authored
9 years ago
by
Jan David Mol
Browse files
Options
Downloads
Plain Diff
Task #8885: Reduce log spam if stations send bad data.
parents
485f68a9
e848facd
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
RTCP/Cobalt/GPUProc/src/Station/StationInput.cc
+16
-4
16 additions, 4 deletions
RTCP/Cobalt/GPUProc/src/Station/StationInput.cc
RTCP/Cobalt/GPUProc/src/Station/StationInput.h
+4
-0
4 additions, 0 deletions
RTCP/Cobalt/GPUProc/src/Station/StationInput.h
with
20 additions
and
4 deletions
RTCP/Cobalt/GPUProc/src/Station/StationInput.cc
+
16
−
4
View file @
2dac1aba
...
...
@@ -169,6 +169,9 @@ namespace LOFAR {
mode
(
ps
.
settings
.
nrBitsPerSample
,
ps
.
settings
.
clockMHz
),
nrBoards
(
ps
.
settings
.
antennaFields
.
at
(
stationIdx
).
inputStreams
.
size
()),
loggedSeenFutureData
(
0
),
loggedNonRealTime
(
0
),
targetSubbands
(
values
(
subbandDistribution
)),
beamletIndices
(
generateBeamletIndices
())
{
...
...
@@ -330,9 +333,14 @@ namespace LOFAR {
const
TimeStamp
now
=
TimeStamp
::
now
(
mode
.
clockHz
());
if
(
deadline
<
now
)
{
// We're too late! Don't process data, or we'll get even further behind!
LOG_ERROR_STR
(
logPrefix
<<
"[block "
<<
current
.
block
<<
"] Not running at real time! Deadline was "
<<
TimeStamp
(
now
-
deadline
,
deadline
.
getClock
()).
getSeconds
()
<<
" seconds ago"
);
// Only emit log lines every minute seconds to prevent spam
if
(
loggedNonRealTime
+
mode
.
secondsToSamples
(
60
)
<
now
)
{
// We're too late! Don't process data, or we'll get even further behind!
LOG_ERROR_STR
(
logPrefix
<<
"[block "
<<
current
.
block
<<
"] Not running at real time! Deadline was "
<<
TimeStamp
(
now
-
deadline
,
deadline
.
getClock
()).
getSeconds
()
<<
" seconds ago"
);
loggedNonRealTime
=
now
;
}
}
else
{
// One core can't handle the load, so use multiple
...
...
@@ -364,7 +372,11 @@ namespace LOFAR {
// We have data (potentially) spilling into `next'.
if
(
next
->
write
(
packet
,
beamletIndices
,
nrBeamletIndices
))
{
LOG_WARN_STR
(
logPrefix
<<
"Received data for several blocks into the future -- discarding."
);
// Only emit log lines every minute seconds to prevent spam
if
(
loggedSeenFutureData
+
mode
.
secondsToSamples
(
60
)
<
now
)
{
LOG_ERROR_STR
(
logPrefix
<<
"Received data for several blocks into the future -- discarding."
);
loggedSeenFutureData
=
now
;
}
}
}
}
...
...
This diff is collapsed.
Click to expand it.
RTCP/Cobalt/GPUProc/src/Station/StationInput.h
+
4
−
0
View file @
2dac1aba
...
...
@@ -112,6 +112,10 @@ namespace LOFAR {
const
size_t
nrBoards
;
std
::
vector
<
SmartPtr
<
Pool
<
RSPData
>
>
>
rspDataPool
;
// [nrboards]
// Whether we emitted certain errors (to prevent log spam)
TimeStamp
loggedSeenFutureData
;
TimeStamp
loggedNonRealTime
;
const
std
::
vector
<
size_t
>
targetSubbands
;
// Mapping of
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment