TMSS-445-merge: Improve test for transformed_output_dataproduct action

SAS/TMSS/backend/test/t_permissions_system_roles.py

@@ -313,11 +313,10 @@ class SystemPermissionTestCase(unittest.TestCase):
 
         self.assertTrue(user.has_perm('tmssapp.process_feedback_and_set_to_finished_if_complete_subtask'))
 
+        # Try to process_feedback_and_set_to_finished_if_complete subtask and assert Paulus can do it within the TO observer group permissions.
         with tmss_test_env.create_tmss_client() as client:
             client.set_subtask_status(self.obs_subtask_id, 'finishing')
-
-        # Try to process_feedback_and_set_to_finished_if_complete subtask and assert Paulus can do it within the TO observer group permissions.
-        response = POST_and_assert_expected_response(self, BASE_URL + '/subtask/%s/process_feedback_and_set_to_finished_if_complete/' % self.obs_subtask_id,
+            response = POST_and_assert_expected_response(self, BASE_URL + '/subtask/%s/process_feedback_and_set_to_finished_if_complete/' % self.obs_subtask_id,
                                                      {}, 200, {},
                                                      auth=self.test_data_creator.auth)
 
@@ -530,11 +529,12 @@ class SystemPermissionTestCase(unittest.TestCase):
 
         # Try to transformed_output_dataproduct subtask and assert Paulus can do it within the TO observer group permissions.
         with tmss_test_env.create_tmss_client() as client:
-            # NOTE: A 404 error is returned because of missing input_dataproducts, not related to user's permissions.
-            self.assertEqual(len(client.get_subtask_input_dataproducts(self.obs_subtask_id)), 0)
+            idps_n = len(client.get_subtask_input_dataproducts(self.obs_subtask_id))
+            # NOTE: A 404 Not found error is returned if input_dataproducts are missing. It is not related to user's permissions.
+            expected_status_code = 404 if idps_n is 0 else 200
             response = GET_and_assert_equal_expected_code(self, BASE_URL + '/subtask/%s/transformed_output_dataproduct?input_dataproduct_id=%s' % (
                                                           self.obs_subtask_id, 1),
-                                                          404,
+                                                          expected_status_code,
                                                           auth=self.test_data_creator.auth)