Skip to content
Snippets Groups Projects

L2SDP-307, working version.

Merged L2SDP-307, working version.
5 unresolved threads
Merged Pieter Donker requested to merge L2SDP-307 into master
5 unresolved threads

Closes L2SDP-307

Merge request reports

Merged by Pieter DonkerPieter Donker 3 years ago (Oct 5, 2021 7:37pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
128 128 bool read_bst_offload_nof_beamlets_per_packet(TermOutput& termout, int format);
129 129 bool write_bst_offload_nof_beamlets_per_packet(const char *data);
130 130
131 bool write_beamlet_output_enable(const char *data);
  • 128 128 bool read_bst_offload_nof_beamlets_per_packet(TermOutput& termout, int format);
    129 129 bool write_bst_offload_nof_beamlets_per_packet(const char *data);
    130 130
    131 bool write_beamlet_output_enable(const char *data);
    132 bool read_beamlet_output_scale(TermOutput& termout, int format);
    133 bool write_beamlet_output_scale(const char *data);
    134 bool read_beamlet_output_nof_beamlets(TermOutput& termout, int format);
    135 bool write_beamlet_output_nof_beamlets(const char *data);
    136 bool read_beamlet_output_hdr_eth_destination_mac(TermOutput& termout, int format);
    137 bool write_beamlet_output_hdr_eth_destination_mac(const char *data);
    138 bool read_beamlet_output_hdr_ip_destination_address(TermOutput& termout, int format);
    139 bool write_beamlet_output_hdr_ip_destination_address(const char *data);
    140 bool write_beamlet_output_hdr_udp_destination_port(const char *data);
  • 46 46
    47 47 #define C_Q_fft 2
    48 48 #define C_N_sub 512
    49 #define C_N_pol_bf 2
    49 50 #define C_N_sub_bf 488
  • 1433 else if ((i * C_S_sub_bf) < nof_beamlets) {
    1434 bset_data = (uint32_t)(C_N_pol_bf * (nof_beamlets - i * C_S_sub_bf) - 1); // 2*()
    1435 }
    1436 else {
    1437 bset_data = -1;
    1438 }
    1439 memcpy(_data, &bset_data, sizeof(int32_t));
    1440 retval &= Write(regname, _data);
    1441 }
    1442 return retval;
    1443 }
    1444
    1445
    1446
    1447
    1448 bool Periph_fpga::read_beamlet_output_hdr_eth_destination_mac(TermOutput& termout, int format)
    • Deze functies voor de beamlet hdr kun je ook combineren met die voor SST, XST en BST in 6 generieke functies? Even opletten dat de BST en beamlets 2 beamsets hebben.

      read_beamlet_output_hdr_eth_destination_mac()
      write_beamlet_output_hdr_eth_destination_mac()
      read_beamlet_output_hdr_ip_destination_address()
      write_beamlet_output_hdr_ip_destination_address()
      read_beamlet_output_hdr_udp_destination_port() <--  deze mist
      write_beamlet_output_hdr_udp_destination_port()

      Dan wordt de code weer wat compacter en beter te testen en te onderhouden.

      Edited by Eric Kooistra
    • changed this line in version 2 of the diff

    • Please register or sign in to reply
  • 2133 2432 return retval;
    2134 2433 }
    2135 2434
    2136 bool Periph_fpga::read_mm_port(TermOutput& termout, const string& port_name, const string& field_name, const int format) {
    2435 bool Periph_fpga::read_all_from_port(TermOutput& termout, const string& port_name, const string& field_name, const int format) {
    • Kun je een comment toevoegen over wanneer je deze generieke functie gebruikt en wanneer een specifieke read functie? (bijv. read_signal_input_mean). Heeft het te maken met of je nog een data conversie moet doen (bijv int to float) ?

      Waarom heb je hem hernoemt van read_mm_port() in read_all_from_port(), want we hebben nog wel write_mm_port() ?

      Edited by Eric Kooistra
    • Please register or sign in to reply
  • Pieter Donker added 1 commit

    added 1 commit

    Compare with previous version

  • Pieter Donker added 1 commit

    added 1 commit

    Compare with previous version

  • merged

  • Pieter Donker mentioned in commit 9d3206d6

    mentioned in commit 9d3206d6

  • Please register or sign in to reply
    Loading