Fix archive images.

See esap-general#184 (closed)

assigned to @kliffen

added 1 commit

• 6976b85e - Try fixing the image size

Compare with previous version

added 6 commits

• 6976b85e...28ee8bb5 - 2 commits from branch master
• b62abc14 - Make the ESAP logo static
• 172a1327 - Try fixing the image size
• e4b86f6c - Fix archive images
• c84fbbef - Minor code fixes

Compare with previous version

Also fixed the image sizing on the main page so they are of similar height.

Before:

After:

Just few implementation comments and syntax. Please take them lightly I dont do js editing in ages.

Also I have noticed there little to no use of await. Is there a reason?

I'm a bit confused with what's going on here. esap-general#184 (closed) just changed some URLs, so it's not obvious why it necessitates such a big diff here.

I like the idea of fixing image sizes, but beyond that it's hard to see exactly what's changed here (if anything) since the diff is full of formatting changes.

It's mainly the ESAP logo is now fixed in the top left corner (it would change something depending on the archive) and those would again be fetched from the ALTA archive. And since the images "are out of our control" I wanted to add a safeguard so that the images would be more or less the same size (which was a valid point made by Nico) and additionally I added an alt text in case it goes missing.

resolved all threads

approved this merge request

resolved all threads

merged

mentioned in commit 9605fcbd