Skip to content
Snippets Groups Projects

Add some more extrapolation in h5parm freqs

Merged Add some more extrapolation in h5parm freqs
more_extrapolate2 into master
1 unresolved thread
Merged Tammo Jan Dijkema requested to merge more_extrapolate2 into master
1 unresolved thread

Another try at https://jira.skatelescope.org/browse/AST-468, previously wrongly implemented in !24 (merged). The problem was the abs: the tolerance was applied also to the right of the start of the first frequency in the h5parm. This was caught by tapplycalh5/testampl4 in DP3.

I'm still working on a test of GetFreqIndex here.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Maik Nijhuis
  • Maik Nijhuis
  • Maik Nijhuis
  • Maik Nijhuis
  • Maik Nijhuis
  • Maik Nijhuis
  • Maik Nijhuis
  • Maik Nijhuis
  • Maik Nijhuis
  • Maik Nijhuis
  • Maik Nijhuis
    Maik Nijhuis @mnijhuis-tos started a thread on the diff
    • src/h5parm/test/th5parm.cc
    94 122 H5Parm h5parm("tH5Parm_tmp.h5", true);
    95 123
    96 124 // Check that something is created
    97 125 BOOST_CHECK_EQUAL(((H5::H5File&)(h5parm)).getNumObjs(), size_t{1});
  • Tammo Jan Dijkema added 1 commit

    added 1 commit

    • 8774c357 - Apply 4 suggestion(s) to 2 file(s)

    Compare with previous version

  • Tammo Jan Dijkema added 2 commits

    added 2 commits

    Compare with previous version

  • Maik Nijhuis approved this merge request

    approved this merge request

  • Tammo Jan Dijkema mentioned in commit e00188db

    mentioned in commit e00188db

  • Tammo Jan Dijkema merged

    merged

  • Tammo Jan Dijkema mentioned in merge request DP3!455 (merged)

    mentioned in merge request DP3!455 (merged)

    • Please register or sign in to reply