Skip to content
Snippets Groups Projects

Parse direction label after point clause and sort Python imports

Merged Bas van der Tol requested to merge ast-1565-parse-direction-label-after-point-clause into master
1 unresolved thread

In a ds9 region file a name can be given to a polygon in the comment after the polygon definition. This name can currently be read by the ds9 region file reader schaapcommon.

However, it is also allowed (at least ds9 accepts it) to specify the name in the comment after the optional point definition, after the polygon definition.

This MR extends the reader, to also parse the comment after a point, and check for a name for the facet there.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 78 78 # Use line length 79, which complies with PEP-8.
    79 79 BLACK="black -l 79"
    80 80
    81 # Sort imports according to PEP-8
    82 ISORT="isort --profile black"
  • Andre Offringa changed title from AST-1565 parse direction label after point clause to Parse direction label after point clause and sort Python imports

    changed title from AST-1565 parse direction label after point clause to Parse direction label after point clause and sort Python imports

  • Andre Offringa requested review from @offringa

    requested review from @offringa

  • added 1 commit

    • 582a9087 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Andre Offringa approved this merge request

    approved this merge request

  • Bas van der Tol enabled an automatic merge when the pipeline for 582a9087 succeeds

    enabled an automatic merge when the pipeline for 582a9087 succeeds

  • mentioned in commit 0a036718

  • Please register or sign in to reply
    Loading