Parse direction label after point clause and sort Python imports
1 unresolved thread
In a ds9 region file a name can be given to a polygon
in the comment after the polygon
definition.
This name can currently be read by the ds9 region file reader schaapcommon.
However, it is also allowed (at least ds9 accepts it) to specify the name in the comment after the optional point
definition, after the polygon
definition.
This MR extends the reader, to also parse the comment after a point
, and check for a name for the facet there.
Merge request reports
Activity
requested review from @dijkema
assigned to @tol
added 1 commit
- c0271fdb - Parse comment after point in ds9 region file reader
added 3 commits
-
c0271fdb...8e43e442 - 2 commits from branch
master
- f62d8933 - Parse comment after point in ds9 region file reader
-
c0271fdb...8e43e442 - 2 commits from branch
added 1 commit
- 63f9636b - Update scripts/format.sh to latest aocommon version
added 1 commit
- 56c615cd - Install isort in docker needed for formatting in ci
added 1 commit
- 3a2d6011 - Add test case for text label after point(...)
removed review request for @dijkema
- Resolved by Bas van der Tol
78 78 # Use line length 79, which complies with PEP-8. 79 79 BLACK="black -l 79" 80 80 81 # Sort imports according to PEP-8 82 ISORT="isort --profile black" requested review from @offringa
enabled an automatic merge when the pipeline for 582a9087 succeeds
mentioned in commit 0a036718
Please register or sign in to reply