Skip to content
Snippets Groups Projects
Mick Veldhuis's avatar
  • 59221fd1 · Install required Python packages in the container
Mick Veldhuis's avatar
  • e5e2f1da · Add requirements for running the scripts
Mick Veldhuis's avatar
  • 6066070e · Add find_brightest_sources step
Mick Veldhuis's avatar
  • 964b2a19 · Add script to find brightest sources
Mick Veldhuis's avatar
opened merge request !14 "Draft: RAP-918 Add step to calculate the apparent flux of the brightest sources" at ResearchAndDevelopment / preprocessing-cwl
Mick Veldhuis's avatar
deleted branch rap-840-add-docs at ResearchAndDevelopment / preprocessing-cwl
Mick Veldhuis's avatar
accepted merge request !9 "RAP-840 Add Read the Docs" at ResearchAndDevelopment / preprocessing-cwl
Mick Veldhuis's avatar
Marcel Loose's avatar
approved merge request !9 "RAP-840 Add Read the Docs" at ResearchAndDevelopment / preprocessing-cwl
Marcel Loose's avatar
commented on merge request !9 "RAP-840 Add Read the Docs" at ResearchAndDevelopment / preprocessing-cwl

Perfect changes.

Mick Veldhuis's avatar
pushed to branch rap-840-add-docs at ResearchAndDevelopment / preprocessing-cwl
Mick Veldhuis's avatar
commented on merge request !9 "RAP-840 Add Read the Docs" at ResearchAndDevelopment / preprocessing-cwl

Then it's maybe better to remove the section here and add a section to running.rst about running the workflow steps inside a container. In hindsigh...

Mick Veldhuis's avatar
commented on merge request !9 "RAP-840 Add Read the Docs" at ResearchAndDevelopment / preprocessing-cwl

Ah right! Good point. I added a comment to those sections that those directories should be mounted.

Marcel Loose's avatar
commented on merge request !9 "RAP-840 Add Read the Docs" at ResearchAndDevelopment / preprocessing-cwl

I think you should not assume that people will always specify an output directory inside the source directory. It will pollute the source directory...

Marcel Loose's avatar
commented on merge request !9 "RAP-840 Add Read the Docs" at ResearchAndDevelopment / preprocessing-cwl

It depends. I'm only saying that the text in your note is incorrect, as it depends on the options you pass to the CWL runner if separate workflow s...

Mick Veldhuis's avatar
commented on merge request !9 "RAP-840 Add Read the Docs" at ResearchAndDevelopment / preprocessing-cwl

Changed it, hope this sounds better?

Mick Veldhuis's avatar
commented on merge request !9 "RAP-840 Add Read the Docs" at ResearchAndDevelopment / preprocessing-cwl

Right, I thought I wouldn't mention the --no-container parameter here yet. Do you think I should?

Mick Veldhuis's avatar
commented on merge request !9 "RAP-840 Add Read the Docs" at ResearchAndDevelopment / preprocessing-cwl

Yes, but presumably someone will mount a directory via -v <source_directory>:<mount_point> (if they're using Docker), then the output directory, e....

Mick Veldhuis's avatar
commented on merge request !9 "RAP-840 Add Read the Docs" at ResearchAndDevelopment / preprocessing-cwl

👍 once this "initial" version of the documentation is available in main, I'll ask the commissioners in the new year.