Restructure HBA-selfcal
This merge requests aims for condensing and simplifying the new feature of HBA-selfcal in LINC
Merge request reports
Activity
assigned to @alex
added 13 commits
-
da7431db...442eafbf - 12 commits from branch
RAP-510-hba-smooth-selfcal - 3c75df2f - Merge remote-tracking branch 'origin/RAP-510-hba-smooth-selfcal' into restructure-HBA-selfcal
-
da7431db...442eafbf - 12 commits from branch
added 6 commits
-
3c75df2f...9e27ae29 - 5 commits from branch
RAP-510-hba-smooth-selfcal - 52532f8c - Merge remote-tracking branch 'origin/RAP-510-hba-smooth-selfcal' into restructure-HBA-selfcal
-
3c75df2f...9e27ae29 - 5 commits from branch
added 73 commits
-
52532f8c...17a2e33d - 72 commits from branch
RAP-510-hba-smooth-selfcal - 9c92a50f - merge
-
52532f8c...17a2e33d - 72 commits from branch
added 5 commits
-
9c92a50f...cbc88533 - 4 commits from branch
RAP-510-hba-smooth-selfcal - c89226e4 - Merge remote-tracking branch 'origin/RAP-510-hba-smooth-selfcal' into restructure-HBA-selfcal
-
9c92a50f...cbc88533 - 4 commits from branch
added 7 commits
-
c89226e4...9fc90441 - 6 commits from branch
RAP-510-hba-smooth-selfcal - 6b0d0ac0 - Merge remote-tracking branch 'origin/RAP-510-hba-smooth-selfcal' into restructure-HBA-selfcal
-
c89226e4...9fc90441 - 6 commits from branch
I think it might be good if this ticket could get an outline of what is desired to be restructured. Your reviews have been quite helpful to me in simplifying and consolidating the first implementation (fewer duplicate steps and consolidated in its own workflow), so perhaps a lot of the restructuring has already been done?
With this merge request I aimed for the following:
- fix all cwltool warnings
- made both selfcal procedures in now completely separated workflows, whereas the HBA part gets all global parameters propagated
- added full logging to the HBA-selfcal part
- remove second concat step for now (maybe extra ticket if still required, I would put it in the
concat.cwlworkflow as an extra step - change defaults to full concat in case user enables HBA selfcal mode
- clearer namings to avoid double steps that should also match the situation in the non-selfcal-mode
- readjusted some defaults to avoid conflicts
Now
finalize.cwlshould have basically no major changes andgsmcal.cwlonly moderate changes to accommodate the extra selfcal step.
Please register or sign in to reply