Skip to content

Make use of aocommon's CoordinateSystem struct

Andre Offringa requested to merge rename-shift-l-m-variables into master

The CoordinateSystem is in many places a useful class to have. However, by having it inside EveryBeam, WSClean can not depend on it, because EveryBeam is optional in WSClean's build. This MR is an almost literal search-and-replace of everybeam::coords::CoordinateSystem to aocommon::CoordinateSystem. The addition of CoordinateSystem to aocommon is in https://gitlab.com/aroffringa/aocommon/-/merge_requests/94.

This MR initially was to rename shift l,m variables (description was: The old name "phase centre dl/dm" is quite confusing and not distinct enough from the l,m pixel scale variables (often called dl, dm)). That is superceded by using aocommon's CoordinateSystem.

The version of EveryBeam is updated to 0.4.0.

Edited by Andre Offringa

Merge request reports