Skip to content

PADRE-12/AST-1217: Reimplement AntennaFlagger

Bram Veenboer requested to merge padre-12-antennaflagger into master

The AntennaFlagger step and its internal Flagger helper class are completely rewritten:

  • Use XTensor instead of vectors inside
  • Remove unneeded preselection of baselines
  • Automatically detect baseline ordering (row for AARTFFAAC, column for LOFAR)
  • Add unit tests for Flagger class: check whether a broken antenna and a broken station are flagged
  • tAntennaFlagger is now a proper integration test
  • Use std::unique_ptr in AntennaFlagger::process
  • Update documentation
  • Remove statistics.h helper file

This new implementation is simpler (thanks to XTensor) and tested much more extensively than the previous version. For a typical AARTFAAC case, processing on 1 Zen 2 CPU core now takes about 100 ms, a bit slower than the ~60 ms before. For now, performance for the AARTFAAC case is good enough. Parallelization and additional optimization (for the LOFAR case) is outside the scope of this MR.

Edited by Bram Veenboer

Merge request reports