Skip to content
Snippets Groups Projects

Fix dde subtract one-off bug

Merged Fix dde subtract one-off bug
fix-dde-subtract-oneoff-bug into master
Merged Tammo Jan Dijkema requested to merge fix-dde-subtract-oneoff-bug into master

Created by: aroffringa

This bug (#168 (closed)) caused DDECal to crash when subtract=true due to a one-off error in the use of itsStepInSolInt.

Merge request reports

Approval is optional

Merged by avatar (Mar 14, 2025 5:08am UTC)

Merge details

  • Changes merged into master with fefd2dd4 (commits were squashed).
  • Deleted the source branch.

  • Closed #168 (closed)

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tammo Jan Dijkema
    Tammo Jan Dijkema @dijkema ·
    Author Owner

    Created by: aroffringa

    Tested, seems to solve the issue.

    As mentioned in the commit log, (unlike I mentioned to tammojan irl) there isn't a bug in GainCal, just in DDECal subtract. This is because the counter that is somewhat inconsistently used, is not used inside the calibrate() function. It's not necessary, as GainCal relies on the data having been set to zero, and 'unset' data therefore doesn't affect the solutions.

Please register or sign in to reply