AST-1637 Use common::Fields in BdaBuffer

• Remove the existing BdaBuffer::Fields and use common::Fields instead.
• Make the fields argument mandatory when creating a BdaBuffer, since there's no obvious default behavior.

added 1 commit

• 7d71e509 - Use common::Fields in BdaBuffer

Compare with previous version

assigned to @mnijhuis-tos

changed the description

marked this merge request as ready

The code modifications are neat and consistent with the new constructors for BdaBuffer.h.

I suggest that in every header file implementing BDA functionality, i.e.BdaBuffer.h, MSBDAReader.h, MSBDAWriter.h, BDAAverager.h, etc. add a reference to the documentation of Baseline Dependent Averaging (BDA). I found this: docs/doxygen/bda.md Once I read that documentation, having a DBA reader, writer, steps and buffers made sense. And also the modifications of this merge request.

approved this merge request

enabled an automatic merge when all merge checks for 7d71e509 pass

resolved all threads

merged

mentioned in commit 86fba922