AST-1637 Support model data in BdaBuffer

assigned to @mnijhuis-tos

added 16 commits

• f89e4ec9...d6693570 - 6 commits from branch master
• 993406c2 - Only read the 'fields to read' in MSBDAReader
• e99de4f1 - Test new BdaBuffer::AddData() function
• ae68de7f - Store BDA visibilities in map; Update GetData functions
• c9d4dbfd - Return null for empty data; Move GetData to BdaBuffer.cc
• 2acfe866 - Remove confusing copy_fields argument
• 69b6f035 - Add AddData/RemoveData/HasData
• 997c999d - Test adding model data
• 54e119eb - Copy model data in copy constructor
• 10ded809 - Update Clear(), including test
• 9198c25e - Test BdaBuffer::RemoveData

Compare with previous version

marked this merge request as draft

changed target branch from master to ast-1637-only-read-bda-required-fields

deleted the ast-1637-only-read-bda-required-fields branch. This merge request now targets the master branch

added 11 commits

• 9198c25e...b63ab94e - 2 commits from branch master
• 0e5b6fd7 - Store BDA visibilities in map; Update GetData functions
• 4b4af7a6 - Return null for empty data; Move GetData to BdaBuffer.cc
• d0d4d6da - Remove confusing copy_fields argument
• 31cd67f7 - Add AddData/RemoveData/HasData
• b6b23e50 - Test adding model data
• d70933ff - Copy model data in copy constructor
• 84c85e6e - Update Clear(), including test
• cab78998 - Test BdaBuffer::RemoveData
• 3a770e0f - Move comment

Compare with previous version

marked this merge request as ready

requested review from @dijkema

Looks good to me, a few minor questions.

added 1 commit

• 6f07b12a - Update BdaDdeCal comment

Compare with previous version

added 1 commit

• 2949c025 - Add default "" argument to HasData/RemoveData

Compare with previous version

resolved all threads

approved this merge request

added 13 commits

• 2949c025...78c61417 - 2 commits from branch master
• 39e175d0 - 1 earlier commit
• 0fecc917 - Return null for empty data; Move GetData to BdaBuffer.cc
• c45c4cd3 - Remove confusing copy_fields argument
• 959dff5f - Add AddData/RemoveData/HasData
• 494613ae - Test adding model data
• d440ff4e - Copy model data in copy constructor
• acafa012 - Update Clear(), including test
• 53df574b - Test BdaBuffer::RemoveData
• 1fa74777 - Move comment
• c7be6bf7 - Update BdaDdeCal comment
• b1767c09 - Add default "" argument to HasData/RemoveData

Compare with previous version

enabled an automatic merge when all merge checks for b1767c09 pass