Refactor applybeam stokes i
Small refactor fix. Applied to the test proposed by @offringa I see a minor speed up of 50 seconds on the whole run:
BEFORE:
2024-Aug-13 12:05:17.067681 Total DP3 time 1329.69 real 19342.4 user 53.82 system
2024-Aug-13 12:05:17.067689 0.2% ( 2183 ms) MSReader
2024-Aug-13 12:05:17.067723 98.8% ( 1313 s) DDECal solve.
2024-Aug-13 12:05:17.067727 49.5% ( 650 s) of it spent in predict
2024-Aug-13 12:05:17.067731 49.2% ( 646 s) of it spent in estimating gains and computing residuals
2024-Aug-13 12:05:17.067735 0.0% ( 4 ms) of it spent in writing gain solutions to disk
2024-Aug-13 12:05:17.067739 Substeps taken:
2024-Aug-13 12:05:17.067743
AFTER:
2024-Aug-13 14:25:55.047551 Total DP3 time 1278.19 real 18035.1 user 50.06 system
2024-Aug-13 14:25:55.047558 0.1% ( 1851 ms) MSReader
2024-Aug-13 14:25:55.047579 98.7% ( 1262 s) DDECal solve.
2024-Aug-13 14:25:55.047584 47.8% ( 602 s) of it spent in predict
2024-Aug-13 14:25:55.047588 51.0% ( 643 s) of it spent in estimating gains and computing residuals
2024-Aug-13 14:25:55.047591 0.0% ( 4 ms) of it spent in writing gain solutions to disk
2024-Aug-13 14:25:55.047595 Substeps taken:
Edited by Mattia Mancini
Merge request reports
Activity
Filter activity
requested review from @offringa
assigned to @mancini
My measurements show 5% improvement during predict:
With master branch: 2024-Aug-13 22:18:22.994982 Total DP3 time 964.83 real 10536.4 user 33.37 system 2024-Aug-13 22:18:22.994986 0.3% ( 3171 ms) MSReader 2024-Aug-13 22:18:22.994997 98.8% ( 953 s) DDECal solve. 2024-Aug-13 22:18:22.995000 66.3% ( 632 s) of it spent in predict 2024-Aug-13 22:18:22.995003 32.6% ( 310 s) of it spent in estimating gains and computing residuals 2024-Aug-13 22:18:22.995006 0.0% ( 1 ms) of it spent in writing gain solutions to disk 2024-Aug-13 22:59:14.112521 Total DP3 time 960.21 real 10510.8 user 32.46 system 2024-Aug-13 22:59:14.112525 0.1% ( 1154 ms) MSReader 2024-Aug-13 22:59:14.112537 99.0% ( 951 s) DDECal solve. 2024-Aug-13 22:59:14.112541 66.3% ( 630 s) of it spent in predict 2024-Aug-13 22:59:14.112543 32.6% ( 309 s) of it spent in estimating gains and computing residuals 2024-Aug-13 22:59:14.112547 0.0% ( 1 ms) of it spent in writing gain solutions to disk With your branch: 2024-Aug-13 22:38:14.099757 Total DP3 time 931.07 real 10050.6 user 32.38 system 2024-Aug-13 22:38:14.099762 0.1% ( 1188 ms) MSReader 2024-Aug-13 22:38:14.099771 99.0% ( 921 s) DDECal solve. 2024-Aug-13 22:38:14.099775 65.1% ( 599 s) of it spent in predict 2024-Aug-13 22:38:14.099778 33.8% ( 311 s) of it spent in estimating gains and computing residuals 2024-Aug-13 22:38:14.099781 0.0% ( 1 ms) of it spent in writing gain solutions to disk 2024-Aug-13 23:18:04.305443 Total DP3 time 932.35 real 10041.7 user 31.81 system 2024-Aug-13 23:18:04.305448 0.1% ( 1152 ms) MSReader 2024-Aug-13 23:18:04.305463 99.0% ( 922 s) DDECal solve. 2024-Aug-13 23:18:04.305467 65.0% ( 599 s) of it spent in predict 2024-Aug-13 23:18:04.305471 33.9% ( 312 s) of it spent in estimating gains and computing residuals 2024-Aug-13 23:18:04.305475 0.0% ( 1 ms) of it spent in writing gain solutions to disk
mentioned in commit 97b1aac6
Please register or sign in to reply