Skip to content

Prepare OnePredict for aocommon's thread pooling

The OnePredict class uses a DynamicFor while a RecursiveFor is alive. In the old system this creates just another bunch of threads, but with the new system this would not work, because the ThreadPool will be occupied. This MR replaces DynamicFor usage with RecursiveFor. It does not yet depend on the new aocommon version, so further changes will be necessary later, but this was a good part to split off first.

As a sidenote, the baseline iteration seems to approach the behaviour of a StaticFor, but uses a DynamicFor. Dynamic scheduling isn't necessary. RecursiveFor always employs dynamic scheduling, but it is not impossible to also implement a statically scheduled variant inside the same class.

Merge request reports

Loading