Skip to content
Snippets Groups Projects

CWG-10 Skeleton C++.

Merged CWG-10 Skeleton C++.
1 unresolved thread
Merged Klaas Kliffen requested to merge CWG-10-skeleton-for-C++ into main
1 unresolved thread

Initial C++ skeleton project.

Edited by Klaas Kliffen

Merge request reports

Merge request pipeline #36967 passed

Merge request pipeline passed for bdb6e1d5

Merged by Mark de WeverMark de Wever 2 years ago (Oct 5, 2022 2:53pm UTC)

Loading

Pipeline #37029 passed

Pipeline passed for f3e4e881 on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Note the current state is more or less a state to start a discussion not really close to being merged.

  • Corné Lukken
  • Looks good, my main concern is with OS support do we want this as Linux only or do we want to have something cross-platform (we can also have something cross-platform that still requires Windows users to use cygwin)

  • Marcel Loose
  • Corné Lukken
  • Thanks for the comments!

  • Mark de Wever
  • Mark de Wever
  • include/hello.hpp 0 → 100644
    1 #ifndef CPP_INCLUDE_HELLO_HPP_INCLUDED
  • Review comments made during the live review.

  • Mark de Wever added 1 commit

    added 1 commit

    Compare with previous version

  • Marcel Loose
  • Marcel Loose
  • Marcel Loose
  • Marcel Loose
  • Marcel Loose
  • Marcel Loose
  • Marcel Loose
  • Marcel Loose
  • Marcel Loose
  • Marcel Loose added 1 commit

    added 1 commit

    • c6bcd4e5 - Fix find command in format-cmake.sh

    Compare with previous version

  • Mark de Wever added 1 commit

    added 1 commit

    Compare with previous version

  • Marcel Loose added 1 commit

    added 1 commit

    • 578f777a - Fix tests not being picked up

    Compare with previous version

  • Corné Lukken
  • Mark de Wever added 1 commit

    added 1 commit

    • 83aec6f3 - Partly adresses review comments.

    Compare with previous version

  • Mark de Wever added 1 commit

    added 1 commit

    • f9209a52 - Partly adresses review comments.

    Compare with previous version

  • Mark de Wever added 1 commit

    added 1 commit

    • abb93e9b - Partly adresses review comments.

    Compare with previous version

  • Mark de Wever added 1 commit

    added 1 commit

    • bcf26d20 - Partly adresses review comments.

    Compare with previous version

  • Mark de Wever marked this merge request as ready

    marked this merge request as ready

  • Mark de Wever added 1 commit

    added 1 commit

    • bdb6e1d5 - Partly adresses review comments.

    Compare with previous version

  • LGTM. There are still two unresolved threads, though.

  • Corné Lukken approved this merge request

    approved this merge request

  • Marcel Loose approved this merge request

    approved this merge request

  • Mark de Wever mentioned in commit f3e4e881

    mentioned in commit f3e4e881

  • merged

  • Please register or sign in to reply
    Loading