Resolve L2SDP-169
2 unresolved threads
2 unresolved threads
Closes L2SDP-169
Merge request reports
Activity
329 329 v.src_out.sync := snk_in.sync; -- only preserve sync when sync interval and nof_pkt interval are aligned, else sync gets lost but could still be recovered from BSN 330 330 v.src_out.bsn := snk_in.bsn; -- use BSN of first packet for merged packet 331 331 v.src_out.channel := snk_in.channel; -- use channel of first packet for merged packet 332 v.src_out.err := snk_in.err; Gaat dit wel goed? Het sosi err field is alleen geldig op de eop. Ik zou dus alle logica voor de err bij de IF snk_in.eop = '1' THEN verwachten. Dit is ook iets om met de tb te verifieren.
Edited by Eric Kooistrachanged this line in version 2 of the diff
236 237 proc_dp_verify_data("verify_snk_in.data", c_rl, c_data_max, c_unsigned_1, clk, verify_en_valid, verify_snk_out.ready, verify_snk_in.valid, verify_snk_in.data, prev_verify_snk_in.data); 237 238 proc_dp_verify_data("verify_snk_in.bsn", c_rl, c_unsigned_0, TO_UNSIGNED(c_verify_data_gap,32), clk, verify_en_sop, verify_snk_out.ready, verify_snk_in.sop, verify_snk_in.bsn, prev_verify_snk_in.bsn); 238 239 proc_dp_verify_data("verify_snk_in.channel", c_rl, c_unsigned_0, TO_UNSIGNED(c_verify_data_gap,32), clk, verify_en_sop, verify_snk_out.ready, verify_snk_in.sop, verify_snk_in.channel, prev_verify_snk_in.channel); 239 proc_dp_verify_data("verify_snk_in.err", c_rl, c_unsigned_0, TO_UNSIGNED(c_verify_data_gap,32), clk, verify_en_eop, verify_snk_out.ready, verify_snk_in.eop, verify_snk_in.err, prev_verify_snk_in.err); mentioned in commit e31e1154
Please register or sign in to reply