Resolve L2SDP-25
All threads resolved!
All threads resolved!
Closes L2SDP-25
Merge request reports
Activity
- Resolved by Jonathan Hargreaves
- Resolved by Jonathan Hargreaves
- Resolved by Jonathan Hargreaves
- Resolved by Jonathan Hargreaves
- Resolved by Jonathan Hargreaves
Hi Jonathan,
I am ready with the review. Sometimes I may have placed a comment at the master file instead of at the branch file, because I was not always sure which file was shown left and right, but I think the comment still applies.
In general can you please check whether some plain integer settings, should be replaced by using named constant to clarify the meaning and traceability of the value.
Please also check whether the purpose and description sections are correct and sufficiently complete.
Cheers, Eric
added 1 commit
- d8438336 - remove g_sim_level, use constants for data path widths
added 1 commit
- 6abb65c6 - Missing hdl_lib_uses_synth in hdllib file, and typos in vhdl
mentioned in commit 1a01109b
Please register or sign in to reply