Skip to content
Snippets Groups Projects

Resolve TMSS-682

Merged Roy de Goei requested to merge TMSS-682 into master
All threads resolved!

Closes TMSS-682

Merge request reports

Approval is optional

Merged by Auke KlazemaAuke Klazema 4 years ago (Mar 23, 2021 9:37am UTC)

Merge details

  • Changes merged into master with 118dfd65.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jörn Künsemöller
  • Jörn Künsemöller
  • Jörn Künsemöller
  • Jörn Künsemöller
  • Jörn Künsemöller
  • Jörn Künsemöller
  • Alright, backend code looks overall quite nicely done.

    Again, we need to wait for the frontend code, but concerning the backend this is almost good to merge. Maybe sort out that variable name in the populate, but I think that's all that should be addressed.

    I made some further general remarks, because the whole structure is relatively complex and naming (which was established before this ticket) does not help to intuitively grasp this easily, at least in my opinion. Maybe we should review that in a contingency sprint or so.

  • Roy de Goei added 1 commit

    added 1 commit

    Compare with previous version

  • Roy de Goei resolved all threads

    resolved all threads

  • Roy de Goei added 28 commits

    added 28 commits

    Compare with previous version

  • merged

  • Auke Klazema mentioned in commit 118dfd65

    mentioned in commit 118dfd65

  • Please register or sign in to reply
    Loading