Skip to content
Snippets Groups Projects

Resolve TMSS-337

Merged Jörn Künsemöller requested to merge TMSS-337 into master
All threads resolved!

Closes TMSS-337

Merge request reports

Approval is optional

Merged by Roy de GoeiRoy de Goei 4 years ago (Nov 5, 2020 4:17am UTC)

Merge details

  • Changes merged into master with 67d7543c.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jörn Künsemöller
  • Code looks good, can be merged. Little confused with the status properties on task and scheduling unit and why the implementation differs from explicitly modeled subtask state, though. But yeah, that was not introduced in this ticket.

  • Actually, I think I understand why they are not modeled (e.g. because a FK reference might clash with subtask states and we always want to derive). But nonetheless, I think we should have a reference table on what states are to be expected here and maybe check that we don't return 'forbidden' values? Anyway, I guess I was just confused because 'observed_end_time' had no intuitive meaning to me... ;)

  • Roy de Goei resolved all threads

    resolved all threads

  • merged

  • Roy de Goei mentioned in commit 67d7543c

    mentioned in commit 67d7543c

  • Please register or sign in to reply
    Loading