Flag invalid solutions in RotationAndDiagonalConstraint

Tammo Jan Dijkemarequested to merge
fix_rotdiag into master

Fixes #316 (github)

I've rewritten this fix to work on master. I also fixed some other issues:

  • When using multiple directions, the weights were not correctly dimensioned (apparently no one uses rotational constrains in multiple directions...), missing the NSubSolutions dimensions.
  • The original fix only flagged the rotation value, not the amplitude and/or phase value.

The MR now also adds a test case for the weights.

Edited by Andre Offringa

Merge request reports